GNOME Bugzilla – Bug 481235
Add Face: header value as Contact's Image
Last modified: 2021-05-19 11:31:54 UTC
Please describe the problem: Hi, I saw with pleasure that Evo 2.12 handles the Face: header, i.e. it displays the sender's photo if it's there. Great. However, there's a new preference to display the photo from the adressbook (apparently), which when set disables the photo from the Face: header. I think that behavior is wrong. Evo should display the photo from Face: if there's no photo in the adressebook, and should even propose to add it to the addressbook. Steps to reproduce: 1. Select "show photo from addressbook" (I don't know the correct english translation) 2. Receive a mail with a Face: header but from someone not in your address book 3. Look at the inexistant photo Actual results: No photo is displayed Expected results: The photo from the Face: header is displayed Does this happen every time? Yes Other information:
same here
http://svn.gnome.org/viewcvs/evolution?view=revision&revision=34333 The bug is fixed. The enhancement request is not implemented yet.
however, with such a feature, you will not be able to see new face headers used by the sender. Also, the quality of the images used in face header will be really low, So are you sure you want this enhancement ?
Well, imagine I want a photo of this guy/gal in my addressbook. It may come from: - the Face: header in an email - the avatar in an IM program (telepathy or pidgin) - some other mean If the only source I have is that Face: header, why couldn't I use it for the addressbook ?
I would like to expand the patch a little bit. The "Show the photograph of sender in the email preview" option only applied to photos stored in the addressbook - not to the Face header functionality. This patch normalizes the behavior of that option - they face is shown in both cases, or suppressed in both depending on the setting, but the source of the face doesn't matter. Attached is a patch that combines that with the bugfix already noted.
Created attachment 105189 [details] [review] patch referred to in comment 5
Please do not combine your patch with something already committed in SVN. I'm not sure if it's necessary to disable this feature based on that option, because the option (based on the documentation) is for searching in address book(s). If you have this in mail itself, then you've got it "for free". Which is fine, isn't it? Maybe it can have some option to disable, but I miss the point for that. Anyway, the core of this bug is to allow user to copy Face header image into his/her contact. I understood it as that, at least. Do you want to do such patch?
Hi, The text for the gui in the option reads "Show the photograph of sender in email preview". It doesn't say anything about the source of the photo. I had that box off and was surprised to still see photos. My patch reconciles behavior with the text.. you could change the text too, I suppose. Take it or leave it - it just struck me as a bug so I humbly offer a proposed fix.
I agree, the option is named in general, no address book info there at all. Unfortunately this bug is against something completely different and we should not steal it. I hope you will agree with it too. Please file a separate bug and attach there updated patch with ChangeLog entry against actual trunk and I will approve it (if it will be correct).
*** Bug 525502 has been marked as a duplicate of this bug. ***
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/evolution/-/issues/ Thank you for your understanding and your help.