GNOME Bugzilla – Bug 481200
gstneonhttpsrc discards GET parameters from URL
Last modified: 2007-09-28 11:59:05 UTC
Please describe the problem: gstneonhttpsrc's location parameter is parsed into components. The path is preserved, but the query argument of the URL are discarded, e.g. http://foo.bar/fubar?one=two&three=four is translated to http://foo.bar/fubar. Steps to reproduce: By specifying a location as suggested above. Actual results: Expected results: Does this happen every time? Other information: I have a patch that fixes this.
Created attachment 96319 [details] [review] Patch for http get parameter discarding bug
Thanks, committed with a minor change (only set the query string to path+"?"+query if query is != NULL, otherwise just use path). 2007-09-28 Sebastian Dröge <slomo@circular-chaos.org> Patch by: Wouter Cloetens <wouter@mind.be> * ext/neon/gstneonhttpsrc.c: (gst_neonhttp_src_dispose), (gst_neonhttp_src_set_location), (gst_neonhttp_src_send_request_and_redirect): * ext/neon/gstneonhttpsrc.h: Don't discard GET parameters from URL if existing. Fixes #481200.
>Thanks, committed with a minor change (only set the query string to >path+"?"+query if query is != NULL, otherwise just use path). That seems superfluous. If the third parameter to g_strjoin() is NULL, it will be interpreted as a sentinel. I haven't checked it, but I expect that to prevent the separator from being appended to the returned string.
From looking at the sources you're right, it's not mentioned in the docs though. Whatever, I'll change it back with the next commit somewhere in the future :)