Bug 480971 – Gnumeric crashes when formatting cells with text that already has formatting

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 480971 - Gnumeric crashes when formatting cells with text that already has formatting


Summary:	Gnumeric crashes when formatting cells with text that already has formatting


Status:	RESOLVED FIXED

Product:	libgoffice
Classification:	Other
Component:	Gtk+
Version:	unspecified
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Morten Welinder
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-09-27 14:39 UTC by Pedro Villavicencio
Modified:	2007-11-29 19:39 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Pedro Villavicencio 2007-09-27 14:39:18 UTC

This bug has been filled here:

https://bugs.launchpad.net/ubuntu/+source/gnumeric/+bug/145370

"Steps to reproduce:
1. Open gnumeric or use File => New to get a blank spreadsheet.
2. In one of the cells, type "ab".
3. Highlight "b" in the equation bar at the top and press CTRL+B to make just the "b" bold.
4. Press Enter to stop editing that cell.
5. Right click the cell with "ab" in it and select Format Cells in the menu.
6. gnumeric crashes."

"The program is running. Exit anyway? (y or n)

+ Trace 165933

Thread 1 (Thread -1231054656 (LWP 8628))

#0 find_builtin
at ../../../goffice/gtk/go-format-sel.c line 551
#1 study_format
at ../../../goffice/gtk/go-format-sel.c line 1139
#2 go_format_sel_set_style_format
at ../../../goffice/gtk/go-format-sel.c line 1543
#3 fmt_dialog_impl
at ../../../src/dialogs/dialog-cell-format.c line 477
#4 context_menu_handler
at ../../src/sheet-control-gui.c line 1720
#5 popup_item_activate
at ../../src/gui-util.c line 469
#6 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#7 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#8 ??
from /usr/lib/libgobject-2.0.so.0
#9 ??
#10 ??

Comment 1 Morten Welinder 2007-09-27 15:32:15 UTC

I am fairly certain that this was already fixed:

2007-04-19  Morten Welinder  <terra@gnome.org>

        * goffice/gtk/go-format-sel.c (find_builtin): Handle
        GO_FORMAT_UNKNOWN without crashing.  [#431256]

Does Ubuntu's libgoffice contain that fix?

Comment 2 Pedro Villavicencio 2007-09-28 13:57:15 UTC

Yes it have it, the version of libgoffice in Ubuntu is 0.4.2, thanks.

Comment 3 Morten Welinder 2007-09-28 21:13:15 UTC

I see the cause for this.

Comment 4 Morten Welinder 2007-09-28 23:55:12 UTC

2007-09-28  Morten Welinder  <terra@gnome.org>

	* goffice/utils/formats.c (go_format_builtins): Add extra NULL for
	GO_FORMAT_MARKUP.  Fixes #480971.


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Comment 5 Jérôme Guelfucci 2007-11-29 17:50:39 UTC

Could you please provide the final patch for this ? Is it safe to apply it on
gnumeric 1.7.11 source ? Thanks.

Comment 6 Morten Welinder 2007-11-29 19:39:51 UTC

http://svn.gnome.org/viewvc/goffice/trunk/goffice/utils/formats.c?r1=1755&r2=1897

Harmless for any version, I think.