After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 480858 - gstqueue code cleaning
gstqueue code cleaning
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 0.10.15
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-27 08:08 UTC by Felipe Contreras (banned)
Modified: 2007-09-28 10:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
My patch. (3.03 KB, patch)
2007-09-27 08:15 UTC, Felipe Contreras (banned) 		committed Details | Review
Diversify the different debug levels (2.14 KB, patch)
2007-09-27 15:47 UTC, Felipe Contreras (banned) 		committed Details | Review
Show empty/fill status of queues (1.90 KB, patch)
2007-09-27 15:48 UTC, Felipe Contreras (banned) 		committed Details | Review

Description Felipe Contreras (banned) 2007-09-27 08:08:43 UTC 
Please describe the problem:
There's no problem

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Felipe Contreras (banned) 2007-09-27 08:15:47 UTC 
Created attachment 96277 [details] [review]
My patch.
Comment 2 Felipe Contreras (banned) 2007-09-27 15:47:25 UTC 
Created attachment 96292 [details] [review]
Diversify the different debug levels
Comment 3 Felipe Contreras (banned) 2007-09-27 15:48:28 UTC 
Created attachment 96293 [details] [review]
Show empty/fill status of queues

A couple more patches to better display debugging stuff.
Comment 4 Wim Taymans 2007-09-28 10:22:56 UTC 
        Patch by: Felipe Contreras <felipe dot contreras at gmail dot com>

        * plugins/elements/gstqueue.c: (update_time_level), (apply_buffer),
        (gst_queue_locked_dequeue), (gst_queue_handle_sink_event),
        (gst_queue_chain), (gst_queue_loop), (gst_queue_src_activate_push):
        Improve debugging. Fixes #480858.

        * plugins/elements/gstqueue.c: (gst_queue_handle_sink_event):
        First patch of code cleanups, use the macros and right arguments in the
        macros to signal and lock the queue. See #480858.