After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 480707 - Memory leak : gstrtpmp4vpay : config buffer is leaked
Memory leak : gstrtpmp4vpay : config buffer is leaked
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-26 18:33 UTC by Antoine Tremblay
Modified: 2007-09-27 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix memlead (717 bytes, patch)
2007-09-26 18:33 UTC, Antoine Tremblay 		committed Details | Review

Description Antoine Tremblay 2007-09-26 18:33:08 UTC 
The config buffer is leaked...

 /* if config string changed or new profile, make new caps */
      if (!equal || newprofile) {
        if (enc->config)
          gst_buffer_unref (enc->config);
        enc->config = gst_buffer_new_and_alloc (i);
        memcpy (GST_BUFFER_DATA (enc->config), data, i);
        gst_rtp_mp4v_pay_new_caps (enc);
      }

Here the config is created and unreffed in any was present but it is never unreffed by itself ...
Comment 1 Antoine Tremblay 2007-09-26 18:33:34 UTC 
Created attachment 96240 [details] [review]
Patch to fix memlead
Comment 2 Wim Taymans 2007-09-27 11:11:22 UTC 
        Patch by: Antoine Tremblay <hexa00 at gmail dot com>

        * gst/rtp/gstrtpmp4vpay.c: (gst_rtp_mp4v_pay_init),
        (gst_rtp_mp4v_pay_finalize), (gst_rtp_mp4v_pay_flush),
        (gst_rtp_mp4v_pay_handle_buffer):
        * gst/rtp/gstrtpmp4vpay.h:
        Free the config string. Fixes #480707.
        Clean up the timestamp code a little.