After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 478692 - Unshipped files in Git trunk
Unshipped files in Git trunk
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-09-20 18:17 UTC by Matthew Barnes
Modified: 2017-03-09 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthew Barnes 2007-09-20 18:17:07 UTC
With GNOME 2.22 development just now getting under way, this seems like a good
time for some fall cleaning.  There's quite a few files still living in
Subversion trunk that we do not ship in Evolution-Data-Server releases.  The
purpose of this bug is to sort out which of those files we *should* be shipping
and which should be deleted.

I'm of the opinion that, in general, trunk should only contain what we ship. 
If we need to resurrect a file down the road we can always fetch it from SCM
archives.  Keeping dead, unshipped source code files in trunk is especially
detrimental to developers because someone will inevitably waste time
maintaining them, not realizing or forgetting they're dead.  I've lost track of
the number of times this has happened to me.

Here are the unshipped Evolution-Data-Server files currently in Subversion trunk:

addressbook/docs/rfc2047.txt  }
addressbook/docs/rfc2425.txt  } I don't think RFCs are
addressbook/docs/rfc2426.txt  } DFSG-compliant
addressbook/docs/rfc2739.txt  }
addressbook/docs/vcard-21.txt }
addressbook/libedata-book/evolutionperson.schema
addressbook/tests/vcard/12.vcf  } Oversight?
addressbook/tests/vcard/13.vcf  }
calendar/backends/caldav/create-account.c
camel/devel-docs/*  } Move these to wiki or project website?
camel/providers/imapp/camel-imapp-exception.h
camel/providers/imapp/camel-imapp-fetch-stream.c
camel/providers/imapp/camel-imapp-fetch-stream.h
camel/providers/nntp/camel-nntp-auth.c
camel/providers/nntp/camel-nntp-auth.h
camel/providers/nntp/camel-nntp-grouplist.c
camel/providers/nntp/camel-nntp-grouplist.h
camel/providers/nntp/camel-nntp-newsrc.c
camel/providers/nntp/camel-nntp-newsrc.h
camel/providers/nntp/camel-nntp-types.h
camel/providers/nntp/camel-nntp-utils.c
camel/providers/nntp/camel-nntp-utils.h
camel/providers/nntp/test-newsrc.c
camel/tests/mime-filter/data/*
camel/tests/smime/pgp-mime.c
camel/tests/smime/pkcs7.c
camel/CODING.STYLE
camel/README.COPYRIGHT
camel/README.HACKING
camel/README.mt
camel/camel-news-address.c
camel/camel-process.c
libedataserver/e-data-server-marshal.list
libedataserverui/e-data-server-ui-marshal.list
po/si.po  } Oversight?
servers/exchange/docs/*
servers/exchange/lib/actest.c
servers/exchange/lib/cptest.c
servers/exchange/lib/davcat.c
servers/exchange/lib/e2k-user-dialog.c
servers/exchange/lib/e2k-user-dialog.h
servers/exchange/lib/ebrowse.c
servers/exchange/lib/fbtest.c
servers/exchange/lib/gctest.c
servers/exchange/lib/ruletest.c
servers/exchange/lib/test-utils.c
servers/exchange/lib/test-utils.h
servers/groupwise/doc/*

(I used meld to compare a Subversion checkout against the latest tarball.)
Comment 1 Matthew Barnes 2007-09-20 18:52:04 UTC
See also bug #478670, bug #478680 and bug #478704.
Comment 2 Ross Burton 2007-09-20 19:59:14 UTC
A few comments:

RFCs should be removed, yes.

addressbook/libedata-book/evolutionperson.schema should be shipped, its the LDAP schema which Evolution uses.  It should be in a better location though.

addressbook/tests/vcard/*.vcf looks like an oversight, yes.

libedataserver/e-data-server-marshal.list is empty and can be removed/

libedataserverui/e-data-server-ui-marshal.list is required... how does the tarball build. :)
Comment 3 Matthew Barnes 2007-09-21 14:33:20 UTC
The camel/README.* and camel/CODING.STYLE files should be shipped.
Comment 4 Milan Crha 2009-04-24 12:22:18 UTC
CalDAV file gone on master. Created commit df99792.
Comment 5 Akhil Laddha 2011-02-10 11:16:39 UTC
Matthew, is this bug still valid in current master (2.91.6) ?
Comment 6 Matthew Barnes 2011-02-12 20:44:07 UTC
Yes.  Here's what we're currently not shipping in 2.91.x:

/addressbook/docs/*
/addressbook/libedata-book/dbus.dtd
/addressbook/libedata-book/evolutionperson.schema
/addressbook/tests/ebook/*  (not all, but many)
/addressbook/vcard/12.vcf
/addressbook/vcard/13.vcf
/camel/db-scrap-tools
/camel/devel-docs
/camel/providers/imapx/camel-imapx-view-summary.*
/camel/providers/nntp/test-newsrc.c
/camel/test/mime-filter/data/*
/camel/CODING.STYLE
/camel/README.COPYRIGHT
/camel/README.HACKING
/camel/README.mt
libedataserverui/gtk-compat.h
/servers/groupwise/doc/*
Comment 7 Milan Crha 2017-03-09 09:31:02 UTC
Since 3.23.1 the tarballs are made from (and by) git, thus what is in git is in tarball. I'm closing this bug report.