GNOME Bugzilla – Bug 478471
"mount usage details" uses hardcoded colours
Last modified: 2008-02-25 14:24:12 UTC
+++ This bug was initially created as a clone of Bug #410658 +++ Bug 410658 added a nice pie chart showing the disk usage/free space. But the code hardcodes the colours; that's bad., esp. when considering a11y with high/low contrast/inverse themes. The colours need to be themeable (and if the theme doesn't set them, the colours should be derived from themed colours, so they blend in).
The best thing that can be done if one wants to change the colours would be to add style properties. However I am not convinced if modifying the colour is enough for the high contrast theme. I would expect a pitch black outline, and the "used" area not filled with a grey, but with a black/transparent pattern.
Created attachment 97784 [details] [review] Proposed patch Proposed patch adds themeable colors chart_color_1 and chart_color_2 in order to used with pie_chart. I've also get the _gtk_color_shade codes from gtkstyle.c in order to get rid of stroke colors. Stroke colors are darker(@chart_color_1) and darker (@chart_color_1). If no color is defined in the theme, then fall back colors is used which is defined previously. chart_color_N can be used in future for GNOME generic chart colors, or can be replaced by whatever naming convention would be used.
Hi Baris and thanks for the patch. If you already haven't done so, can you please bring up the patch on the nautilus mailing list [1] so that it can get review from the maintainers? Thanks! [1] nautilus-list@gnome.org
commited.