After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 478401 - gstbasesrc.c ref count bug
gstbasesrc.c ref count bug
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-19 20:03 UTC by Steve Fink
Modified: 2007-09-19 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix double deref in gstbasesrc.c for custom events (690 bytes, patch)
2007-09-19 20:05 UTC, Steve Fink 		none Details | Review

Description Steve Fink 2007-09-19 20:03:44 UTC 
The new addition to gstbasesrc to relay custom events has a refcounting bug. It calls gst_pad_push_event() (which eats the reference) and then gst_event_unref() (which eats it again).

I'm attaching a simpleminded patch, but maybe Wim will want to do it by avoiding the unref() instead.
Comment 1 Steve Fink 2007-09-19 20:05:45 UTC 
Created attachment 95864 [details] [review]
Fix double deref in gstbasesrc.c for custom events
Comment 2 Wim Taymans 2007-09-19 20:40:14 UTC 
        * libs/gst/base/gstbasesrc.c: (gst_base_src_send_event):
        Don't unref the event after pushing it. Fixes #478401.