GNOME Bugzilla – Bug 478363
Missing thumbnail frames
Last modified: 2008-01-18 19:30:18 UTC
Nautilus 2.20.0 does not show thumbnail frames anymore. However: if I do a “touch $image.jpg” and refresh the Nautilus view (Ctrl-R), the new thumbnail has a frame. After a Nautilus restart (killall nautilus) the frame is gone again. I already tried a “rm -rf ~/.thumbnails”, but it did not help. I'm pretty sure this worked correctly in 2.19.91.
I can confirm this bug. It came with 2.20.
Second confirmation here with 2.20.
Christian, could you look at this. Its likely from the async thumbnail loading patch.
Looks like the asynchronous loading function should also add a frame for thumbnails if they don't have any alpha channels, similar to its synchronous variant nautilus-icon-factory.c:load_icon_file(). I'll attach a quick patch, it doesn't look very pretty. I didn't want to change nautilus_thumbnail_frame_image semantics, I hope it's OK. Sorry that I didn't note this during hacking. I usually install the development version into a prefix other than /usr, and just install the src/ contents, so I'm used to lack of thumbnail frames and didn't consider it.
Created attachment 95921 [details] [review] quick patch
Thanks Christian your patch seems to work.
Looks good. Please commit (to head and 2.20 branch)
note that the async thumbnailing also create bug #480608
Committed, closing.
I've applied the patch to nautilus 2.20.0 but I still have the problem described above. For example: if I take a screenshot (png) with gnome-screenshot, it will never get a border. If I do convert screenshot.png screenshot.jpg the jpg file gets a border and if I then do convert screenshot.jpg screenshot2.png the new png file will get a border!