GNOME Bugzilla – Bug 477705
atk_object_connect_property_change_handler: guint instead of gulong
Last modified: 2013-12-09 17:29:08 UTC
atk_object_connect_property_change_handler returns an ID as guint. The implementation of this function uses g_signal_connect_closure_by_id which returns the ID as gulong though. So if the latter ID is greater than the maximum guint value(e.g. on architectures x86_64, ia64, ppc64, s390X where sizeof(long) = 8, sizeof(int) = 4), the ID returned by atk_object_connect_property_change_handler cannot be processed properly by atk_object_remove_property_change_handler. (atk_object_remove_property_change_handler calls g_signal_closure_disconnect to remove a handler with a given gulong ID). The detailed bug description can be found at: http://linuxtesting.org/results/report?num=S0567
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 . PLEASE NOTE: If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla. Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Sorry for the delay answering this bug. (In reply to comment #0) > atk_object_connect_property_change_handler returns an ID as guint. The > implementation of this function uses g_signal_connect_closure_by_id which > returns the ID as gulong though. I agree that this is an error. Anyway, at this moment I think that those methods should be deprecated, so this issue is a relevant. So adding a dependency with bug 666210
(In reply to comment #2) > Sorry for the delay answering this bug. > > (In reply to comment #0) > > atk_object_connect_property_change_handler returns an ID as guint. The > > implementation of this function uses g_signal_connect_closure_by_id which > > returns the ID as gulong though. > > I agree that this is an error. Anyway, at this moment I think that those > methods should be deprecated, so this issue is a relevant. > > So adding a dependency with bug 666210 And finally, those methods were marked as deprecated. As part of that deprecation, the default implementation of that method was removed, making the bug fixed.