After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 476128 - Printf format fixes
Printf format fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-12 08:16 UTC by Peter Kjellerstedt
Modified: 2007-09-12 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix compiler warnings in gst-plugins-bad (5.58 KB, patch)
2007-09-12 08:17 UTC, Peter Kjellerstedt 		committed Details | Review

Description Peter Kjellerstedt 2007-09-12 08:16:29 UTC 
Please describe the problem:
Here is a patch to fix a couple of compiler warnings in gst-plugins-bad (am I the only one compiling with debug enabled?).

I am not 100% sure about the change to gst_deinterleave_process() in gst-plugins-bad/gst/interleave/deinterleave.c (the code is just too messy), but I think the ret variable always gets a value, and that it is just the compiler which cannot detect this (which I can fully understand after having looked at the code) and thereby issues a warning about the ret variable possibly being used uninitialized.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Peter Kjellerstedt 2007-09-12 08:17:03 UTC 
Created attachment 95410 [details] [review]
Fix compiler warnings in gst-plugins-bad
Comment 2 Tim-Philipp Müller 2007-09-12 08:45:17 UTC 
Committed, thanks:

 2007-09-12  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Peter Kjellerstedt  <pkj at axis com>

        * gst-libs/gst/app/gstappsink.c:
        * gst/flv/gstflvdemux.c:
        * gst/flv/gstflvparse.c:
        * gst/interleave/deinterleave.c:
        * gst/switch/gstswitch.c:
          Printf format fixes (#476128).

(The reason most of us don't get these warnings is that the compiler doesn't/can't check the printf format if the printf extension is available, because it would warn about the special printf extensions GStreamer registers)