After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 475451 - [decodebin2] leaks ghostpad
[decodebin2] leaks ghostpad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
: 446759 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-09-10 12:41 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2007-11-09 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
release ghostpads from active group in gst_decode_group_free (2.55 KB, patch)
2007-09-10 12:43 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
free ghost pads (927 bytes, patch)
2007-11-06 06:52 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
accepted-commit_now Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-10 12:41:12 UTC
24 (12 direct, 12 indirect) bytes in 1 blocks are definitely lost in loss record 3,873 of 3,994
   at 0x4021835: malloc (vg_replace_malloc.c:207)
   by 0x41592C5: g_malloc (gmem.c:131)
   by 0x4168E97: g_slice_alloc (gslice.c:777)
   by 0x414FC1A: g_list_append (glist.c:69)
   by 0x471FB53: gst_decode_group_expose (gstdecodebin2.c:1826)
   by 0x47223A0: pad_added_group_cb (gstdecodebin2.c:1179)
   by 0x4723876: caps_notify_group_cb (gstdecodebin2.c:1267)
   by 0x40F40F8: g_cclosure_marshal_VOID__PARAM (gmarshal.c:531)
   by 0x40E762A: g_closure_invoke (gclosure.c:490)
   by 0x40F8102: signal_emit_unlocked_R (gsignal.c:2440)
   by 0x40F9626: g_signal_emit_valist (gsignal.c:2199)
   by 0x40F97E8: g_signal_emit (gsignal.c:2243)
   by 0x40EBBA0: g_object_dispatch_properties_changed (gobject.c:563)
   by 0x405A860: gst_object_dispatch_properties_changed (gstobject.c:510)
   by 0x40E83FE: g_object_notify_dispatcher (gobject.c:245)
   by 0x40EC6E1: g_object_notify (gobjectnotifyqueue.c:123)
   by 0x4084FEB: gst_pad_set_caps (gstpad.c:2376)
   by 0x4AA7512: gst_mp3parse_chain (gstmpegaudioparse.c:943)
   by 0x4086508: gst_pad_chain_unchecked (gstpad.c:3453)
   by 0x4086BEA: gst_pad_push (gstpad.c:3621)
   by 0x4774C8A: gst_multi_queue_loop (gstmultiqueue.c:618)
   by 0x40A0C35: gst_task_func (gsttask.c:192)
   by 0x41714D7: g_thread_pool_thread_proxy (gthreadpool.c:265)
   by 0x416FB7E: g_thread_create_proxy (gthread.c:591)
   by 0x41C731A: start_thread (in /lib/tls/i686/cmov/libpthread-2.5.so)
   by 0x42A957D: clone (in /lib/tls/i686/cmov/libc-2.5.so)

gst_decode_group_expose() adds ghostpads to the list and this list is only freed in gst_decode_group_hide().
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-10 12:43:02 UTC
Created attachment 95275 [details] [review]
release ghostpads from active group in gst_decode_group_free

gstdecodebin2.c |   10 ++++++++++
1 file changed, 10 insertions(+)
Comment 2 Edward Hervey 2007-09-10 13:07:54 UTC
It doesn't seem to be the right patch :)
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-10 14:12:01 UTC
yeah, it just fixes the leak. Any better idea?
Comment 4 Tim-Philipp Müller 2007-09-11 09:47:59 UTC
*** Bug 446759 has been marked as a duplicate of this bug. ***
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-25 07:37:22 UTC
Edward, any hint how you would like this to be *properly fixed* would really be appreciated.
Comment 6 Tim-Philipp Müller 2007-11-05 15:43:31 UTC
Stefan: got the right patch somewhere by any chance?
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2007-11-06 06:52:17 UTC
Created attachment 98627 [details] [review]
free ghost pads

I can commit if okay. Please review.
Comment 8 Edward Hervey 2007-11-07 08:12:59 UTC
looks fine to me, can someone else also confirm ?
Comment 9 Wim Taymans 2007-11-09 10:55:57 UTC
commit!
Comment 10 Stefan Sauer (gstreamer, gtkdoc dev) 2007-11-09 15:54:09 UTC
2007-11-09  Stefan Kost  <ensonic@users.sf.net>

	* gst/playback/gstdecodebin2.c:
	  Dont leak ghostpad. Fixes #475451.