GNOME Bugzilla – Bug 474914
Accept front.jpg as album artwork
Last modified: 2018-05-24 12:51:04 UTC
[ From http://bugs.debian.org/441328 ] Adam Borowski <kilobyte@angband.pl> submitted this request to Debian, and also provided the fix; "When Rhythmbox is looking for album artwork to display, it looks first in the directory the file is in for images named "cover.*", "folder.*", etc. It fails to accept random names, which is questionable -- but that's an understandable design decision. If you prefer to look for fixed files only, though, please accept at least front.jpg which appears to be the most frequent name I happen to see in the wild. Patch: plugins/artdisplay/artdisplay/LocalCoverArtSearch.py < IMAGE_NAMES = ["cover", "album", "albumart", ".folder", "folder"] > IMAGE_NAMES = ["cover", "album", "albumart", ".folder", "folder", "front"] As a note, here are the stats for my ~/mp3/: 33 front.jpg 24 back.jpg 12 cover.jpg 6 folder.jpg 2 inlay.jpg 1 tvangeste.jpg 1 summoning_stronghold_cd.jpg 1 summoning_stronghold_b.jpg 1 summoning_stronghold_a.jpg [ snipped the rest ] "
Would it make sense add this as a GConf key? That would allow users who required additional names in this list to add them, but still allow a standard list to be in place. Then, we could allow the user to maintain the list in the Properties dialog. Either way, I agree that 'front' should be an acceptable prefix for the image. I'll implement a patch for this.
I'm working on a patch to move this setting into GConf. I have a question about GNOME policy re: GConf Defaults and setting keys. Namely, if the Key/Value I'm looking up (currently: /apps/rhythmbox/plugins/artdisplay/image_names), and it doesn't exist, is it considered appropriate to create the key at that time with the default values? Or should I leave it blank and simply initialize the local storage of the IMAGE_TYPES list to the default value?
Created attachment 96151 [details] [review] Adds Local Image Names to search to Gconf Allows the user to specify a custom list in Gconf for the file names to search for local art. Also adds 'front' to the default list. I updated the rhythmbox.schemas file to include the new gconf key created for this patch. I also rewrote LocalCoverArtSearch.get_best_match_urls() because it didn't actually appear to be testing against the file names searched for.
I tried it out, and it seems to work just as intended. Nice work! :)
Created attachment 96736 [details] [review] Adds a preferences dialog to the coverart plugin This patch adds a preferences window to the cover art plugin. The only thing in this window now is a simplified GUI to add entries to the GConf key introduced in this patch. I am still tweaking the Glade file.
Created attachment 96737 [details] [review] GUI Cleanup Sorry about the spam. Cleaned up the Preferences dialog, I think it looks cleaner.
I'm not sure we'd want a preference for that though. Maybe a GConf-only key with nice defaults would be enough, no?
What about this issue? 0.13.1 still do not recognize "front.jpg"..... I think this has been forgotten at all......
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/432.