After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 47480 - fix portability issue with modules/nfs-method.c on Solaris8
fix portability issue with modules/nfs-method.c on Solaris8
Status: RESOLVED INCOMPLETE
Product: gnome-vfs
Classification: Deprecated
Component: Module: (other)
cvs (head)
Other Solaris
: Normal normal
: 2.0
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2001-03-06 23:08 UTC by Ben Taylor
Modified: 2009-01-19 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ben Taylor 2001-09-10 01:08:33 UTC
This patch fixes modules/nfs-method.c to compile with no errors on 
Solaris8-X86.  

1) bzero is defined in <strings.h> which is found automatically by configure.
   Just add the "#include <strings.h> if HAVE_STRING_H is defined
2) add a check for rpc/clnt_soc.h in configure.in If it exists, then add
   #include <rpc/rpc.h> and #include <rpc/clnt_soc.h>.
3) add HAVE_RPC_CLNT_SOC_H define to config.h.in
3) fix cast issue with pointers in the structures defined in rpc/clnt_soc.h


--- ./modules/nfs-method.c.ORIG Tue Mar  6 19:29:56 2001
+++ ./modules/nfs-method.c      Tue Mar  6 19:30:13 2001
@@ -41,6 +41,13 @@
 #include <unistd.h>
 #include <utime.h>
 #include <string.h>
+#ifdef HAVE_STRINGS_H
+#include <strings.h>
+#endif
+#ifdef HAVE_RPC_CLNT_SOC_H
+#include <rpc/rpc.h>
+#include <rpc/clnt_soc.h>
+#endif
 
 #include <libgnomevfs/gnome-vfs-mime.h>
 #include <libgnomevfs/gnome-vfs-module.h>
@@ -190,14 +197,14 @@
 {
        /* create TCP clients */
        if ((c->mount_client = clnttcp_create(c->mount_server_addr,
-                                       MOUNTPROG, MOUNTVERS,
-                                       &c->mount_sock, 0, 0)) == NULL) {
+                                       (int)MOUNTPROG, MOUNTVERS,
+                                       &c->mount_sock, (uint_t)0, (uint_t)0))
== NULL) {
                clnt_pcreateerror("clnttcp_create");
                return GNOME_VFS_ERROR_SERVICE_NOT_AVAILABLE;
        }
        if ((c->mount_client = clnttcp_create(c->nfs_server_addr,
                                        NFS_PROGRAM, NFS_VERSION,
-                                       &c->nfs_sock, 0, 0)) == NULL) {
+                                       &c->nfs_sock, (uint_t)0, (uint_t)0)) ==
NULL) {
                clnt_pcreateerror("clnttcp_create");
                return GNOME_VFS_ERROR_SERVICE_NOT_AVAILABLE;
        }
--- ./configure.in.ORIG Tue Mar  6 19:28:57 2001
+++ ./configure.in      Tue Mar  6 21:00:26 2001
@@ -178,7 +178,7 @@
 AC_SUBST(VFS_SIZE_PRINTF)
 AC_SUBST(VFS_OFFSET_PRINTF)
 
-AC_CHECK_HEADERS(sys/resource.h sys/vfs.h sys/mount.h sys/statvfs.h)
+AC_CHECK_HEADERS(rpc/clnt_soc.h sys/resource.h sys/vfs.h sys/mount.h
sys/statvfs.h)
 
 dnl turn warnings into errors to enforce clean code
 
--- ./config.h.in.ORIG  Tue Mar  6 19:30:39 2001
+++ ./config.h.in       Tue Mar  6 21:00:37 2001
@@ -209,6 +209,9 @@
 /* Define if you have the <nl_types.h> header file.  */
 #undef HAVE_NL_TYPES_H
 
+/* Define if you have the <rpc/clnt_soc.h> header file.  */
+#undef HAVE_RPC_CLNT_SOC_H
+
 /* Define if you have the <stdlib.h> header file.  */
 #undef HAVE_STDLIB_H



------- Additional Comments From darin@bentspoon.com 2001-03-06 18:29:12 ----

Since we don't compile nfs-method.c any more, I'm not sure whether this matters.



------- Additional Comments From snickell@stanford.edu 2001-07-23 00:36:03 ----

Taking bugs previously assigned to Pavel, assigning them to myself. Will parse
them out at my leisure , but many are GnomeVFS bugs we should look at for 2.0



------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:08 -------
Comment 1 Maciej Stachowiak 2001-10-21 07:12:42 UTC
Should be easy to fix since there is a patch, but not very important.
Comment 2 Christian Neumair 2006-01-06 17:21:49 UTC
Thanks for your bug report!
Is this still relevant? I'm very interested in getting this fixed, but I don't know the solaris header scheme, maybe it was modified since 2001.
Ben: Can you provide a recent patch?
Comment 3 André Klapper 2006-09-29 19:55:34 UTC
maciej: *ping* - can you please answer christian's question? thanks in advance. 

would be nice to get some up-to-date feedback from the sun solaris folks here if this is still an issue, thanks a lot in advance!
Comment 4 Pavel Šefránek 2008-02-29 16:26:57 UTC
Possibly obsolete as we are looking forward to gio/gvfs. Andre, what's your opinion?
Comment 5 Christoph Wurm 2009-01-19 20:25:58 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!