GNOME Bugzilla – Bug 474666
sabayon prevents logins (in ltsp) if no user profiles are existing
Last modified: 2007-12-19 18:33:56 UTC
Please describe the problem: sabayon-apply will always return 1 if no user profile is existing, that will make the Xsession script fail and stop the login process. the patch attached to https://bugs.launchpad.net/ubuntu/+source/sabayon/+bug/38410 (applied in ubuntu) makes that behavior optional, so users without a profile can still log in. Steps to reproduce: use an ltsp5 setup on debian or ubuntu, install sabayon, try to log in without having profiles created Actual results: no login possible Expected results: login possible Does this happen every time? yes Other information:
I can't find the Ubuntu patch. Please attach it to this bug report. The right thing here is not to have an option not to exit(1), but rather to have a well-defined set of error codes: 0 - success 1 - fatal failure (script crashed, etc.) 2 - recoverable failure (a part of the profile could not be applied) 3 - didn't have a user profile Attaching patch to do this.
Created attachment 101272 [details] [review] sabayon-bgo474666-sabayon-apply-no-profile-exit-code.diff I just committed this to trunk. 2007-12-19 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=474666 - In X startup scripts, a way is needed to detect if there was no user profile for the user. * lib/util.py (EXIT_CODE_NO_USER_PROFILE): New exit code of 3 for sabayon-apply when no user profile can be found for the user. * admin-tool/sabayon-apply: Exit with util.EXIT_CODE_NO_USER_PROFILE if no profile is found for the user.