GNOME Bugzilla – Bug 474429
Untranslat(ed|able) items in toolbar editor
Last modified: 2007-09-09 22:24:54 UTC
The drop-down list items aren't I18N'd (only the “default” item is). I guess it belongs more to the I18N component than to the Toolbar one. Patches for the sources and for the French po-file follow. Also, when running “make update-po” in “po/”, I noticed that the diff was cluttered by line wrapping. I guess one might want to somehow force (or educate translators, I don't know how commits are done) running “msgcat” on the po files before committing them. They would also be more readable. I guess that providing you with the following patches are sufficient, and that you'll run “make update-po” and the like on your side, right?
Created attachment 95100 [details] [review] Add missing I18N to the source
Created attachment 95101 [details] [review] Add French L10N for the missing I18N
For some reason, these entries aren't translated at runtime. I guess I might be overlooking something, but will check gettext manual later. Hopefully, given the source patch, someone will be able to update his/her $LANG.po file and figure out what I'm missing. :)
I see the problem. We used to take the strings from the GNOME control centre gettext domain (the "Menu & Toolbars" capplet), but now they're in the Appearance capplet but in a format that we cannot use. What's missing from your patch is to change dgettext (CONTROL_CENTRE_DOMAIN, text); to just call _() directly instead. (And remove all code doing anything with CONTROL_CENTRE_DOMAIN). For the fr.po update, please open another bug (product: l10n).
Created attachment 95197 [details] [review] Remove the CENTRE references, make strings translatable I see no more references to /centre/i in this file and its header. Also, updating po/fr.po with the appropriate strings make them appear as expected. Thanks for the pointers (and I'm filing an L10N bug right now).
Thanks! trunk only since it's a string change; not sure it's worth trying to get approval for gnome-2-20...
Committed to trunk. Closing this bug as FIXED. 2007-09-09 Cosimo Cecchi <cosimoc@svn.gnome.org> * src/ephy-toolbar-editor.c: (ephy_toolbar_editor_constructor): Marks as translatable some toolbar editor strings and removes references to old Control Center gettext domain. Fixes bug #474429. Patch by Cyril Brulebois.
If I understand correctly, this is NOT a string change, rather a fix for a translation regression. Besides, making previously untranslated strings translatable is never a string freeze break. Adding new strings / changing current strings is.
Ok then, let's get this on gnome-2-20 too.
Committed to gnome-2-20, and I sent a notification [1] to gnome-i18n list for this bug. Closing as FIXED. [1] http://mail.gnome.org/archives/gnome-i18n/2007-September/msg00140.html