GNOME Bugzilla – Bug 47364
'make check' fails in en_GB and ja_JP (also, we should test other locales)
Last modified: 2005-10-04 11:24:31 UTC
It fails at varying levels in different locales. We should consider wiring tinderbox to run checks in more than just the en_US locale. For example: LC_ALL=en_GB make check FAIL: check failed in nautilus-glib-extensions.c, line 1364 evaluated: test_strftime ("%m/%d/%y, %I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 01/01/00, 01:00 AM got: 01/01/00, 01:00 FAIL: check failed in nautilus-glib-extensions.c, line 1365 evaluated: test_strftime ("%-m/%-d/%y, %-I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 1/1/00, 1:00 AM got: 1/1/00, 1:00 FAIL: check failed in nautilus-glib-extensions.c, line 1366 evaluated: test_strftime ("%_m/%_d/%y, %_I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 1/ 1/00, 1:00 AM got: 1/ 1/00, 1:00 LC_ALL=ja_JP make check running nautilus_self_check_string running nautilus_self_check_string_list running nautilus_self_check_enumeration running nautilus_self_check_preferences running nautilus_self_check_scalable_font running nautilus_self_check_font_manager running nautilus_self_check_string_map running nautilus_self_check_art_extensions running nautilus_self_check_gdk_pixbuf_extensions running nautilus_self_check_glib_extensions FAIL: check failed in nautilus-glib-extensions.c, line 1364 evaluated: test_strftime ("%m/%d/%y, %I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 01/01/00 ¸áÁ° 01:00 got: 01/01/00, 01:00 ¸áÁ° FAIL: check failed in nautilus-glib-extensions.c, line 1365 evaluated: test_strftime ("%-m/%-d/%y, %-I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 1/1/00 ¸áÁ° 1:00 got: 1/1/00, 1:00 ¸áÁ° FAIL: check failed in nautilus-glib-extensions.c, line 1366 evaluated: test_strftime ("%_m/%_d/%y, %_I:%M %p", 2000, 1, 1, 1, 0, 0) expected: 1/ 1/00 ¸áÁ° 1:00 got: 1/ 1/00, 1:00 ¸áÁ° running nautilus_self_check_gdk_extensions running nautilus_self_check_gdk_font_extensions running nautilus_self_check_search_uri FAIL: check failed in nautilus-search-uri.c, line 701 evaluated: nautilus_search_uri_to_human ("search:[][]file_name contains stuff") expected: ̾Á°¤ÎÃæ¤Ë "stuff" ¤ò´Þ¤à¥¢¥¤¥Æ¥à got: ¥¢¥¤¥Æ¥à ̾Á°¤Ë"stuff"¤ò´Þ¤à FAIL: check failed in nautilus-search-uri.c, line 703 evaluated: nautilus_search_uri_to_human ("search:[][]file_type is file") expected: Ä̾ï¥Õ¥¡¥¤¥ë got: ¥¢¥¤¥Æ¥à Ä̾ï¥Õ¥¡¥¤¥ë¤Ç¤¢¤ë¤â¤Î FAIL: check failed in nautilus-search-uri.c, line 706 evaluated: nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file") expected: ̾Á°¤ÎÃæ¤Ë "stuff" ¤ò´Þ¤à¥¢¥¤¥Æ¥à¤ÇÄ̾ï¥Õ¥¡¥¤¥ë got: ¥¢¥¤¥Æ¥à ̾Á°¤Ë"stuff"¤ò´Þ¤à and Ä̾ï¥Õ¥¡¥¤¥ë¤Ç¤¢¤ë¤â¤Î FAIL: check failed in nautilus-search-uri.c, line 711 evaluated: nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file" " & size smaller_than 2000") expected: ̾Á°¤ÎÃæ¤Ë "stuff" ¤ò´Þ¤à¥¢¥¤¥Æ¥à¤Ç 2000 ¥Ð¥¤¥È°Ê²¼¤ÎÄ̾ï¥Õ¥¡¥¤¥ë got: ¥¢¥¤¥Æ¥à ̾Á°¤Ë"stuff"¤ò´Þ¤à, Ä̾ï¥Õ¥¡¥¤¥ë¤Ç¤¢¤ë¤â¤Î and 2000¥Ð¥¤¥È¤è¤ê¾®¤µ¤¤ FAIL: check failed in nautilus-search-uri.c, line 715 evaluated: nautilus_search_uri_to_human ("search:[][]file_name contains medusa & file_type is directory") expected: ̾Á°¤ÎÃæ¤Ë "medusa" ¤ò´Þ¤à¥¢¥¤¥Æ¥à¤Ç¥Õ¥©¥ë¥À got: ¥¢¥¤¥Æ¥à ̾Á°¤Ë"medusa"¤ò´Þ¤à and ¥Õ¥©¥ë¥À¤Ç¤¢¤ë¤â¤Î running nautilus_self_check_file_utilities running nautilus_self_check_file_operations FAIL: check failed in nautilus-file-operations.c, line 2377 evaluated: get_duplicate_name ( gettext ("foo foo (100000000000000th copy).txt"), 1) expected: foo foo (¥³¥Ô¡¼).txt got: foo foo (101ÈÖÌܤΥ³¥Ô¡¼).txt running nautilus_self_check_background running nautilus_self_check_directory running nautilus_self_check_file running nautilus_self_check_icon_container running nautilus_self_check_icon_factory running nautilus_self_check_smooth_text_layout_cache ------- Additional Comments From darin@bentspoon.com 2001-03-05 08:12:59 ---- There's nothing wrong with "make check". We just need to properly translate the test results to match the format used in that locale. ------- Additional Comments From darin@bentspoon.com 2001-03-05 08:21:12 ---- This is easy to fix for each individual locale. The real issue is covering all the locales. ------- Additional Comments From darin@bentspoon.com 2001-03-05 09:23:30 ---- I fixed en_GB. ------- Additional Comments From don@eazel.com 2001-03-05 10:07:58 ---- Is this really required for 1.0 or GNOME 1.4? Isn't this something only we would see internally during our build and test cycles? ------- Additional Comments From darin@bentspoon.com 2001-03-05 10:23:46 ---- It affects "make distcheck", something that's reasonable for someone to do in the package-building process. But I can imagine shipping with it broken. I don't really know what the standard is out there for whether "distcheck" passes or not. ------- Additional Comments From don@eazel.com 2001-03-05 12:30:20 ---- OK, I'm moving this out to 1.2 then. Dan, feel free to smack me if this is the wrong thing to do. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:06 -------
Changing to "old" target milestone for all bugs laying around with no milestone set.
Still not fixed in 2.0.x?
I don't get the same error with LC_ALL=jp_JP, but the check does fail. But so it seems to fail for other locales, including the default. So I am not sure if this is fixed. I tested with 2.1.2
*** Bug 45406 has been marked as a duplicate of this bug. ***
Created attachment 52247 [details] [review] Proposed patch I've also submitted the attached patch to the nautilus mailing list [1] for review. [1] http://mail.gnome.org/archives/nautilus-list/2005-September/msg00130.html
The patch was committed some time ago, closing.