After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 473208 - ghex crash in search
ghex crash in search
Status: RESOLVED FIXED
Product: ghex
Classification: Applications
Component: general
2.8.x
Other All
: Normal critical
: ---
Assigned To: Jaka Mocnik
Jaka Mocnik
: 532184 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-09-03 15:17 UTC by Stanislav Brabec
Modified: 2013-02-19 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ghex-empty-search-crash.patch (983 bytes, patch)
2007-09-03 15:28 UTC, Stanislav Brabec 		needs-work Details | Review

Description Stanislav Brabec 2007-09-03 15:17:22 UTC 
Steps to reproduce:
If search field become empty, ghex crashes (OpenSUSE 10.3 beta1 x86_64, GNOME 2.19).

How to reproduce:
1. Open Any file
2. Press Ctrl+F
3. Type 00 and press BackSpace


Stack trace:

+ Trace 160109

  • #0 IA__g_utf8_validate
    at gutf8.c line 1568
  • #1 strdup_len
    at gconvert.c line 1003
  • #2 IA__g_locale_to_utf8
    at gconvert.c line 1069
  • #3 accessible_gtk_hex_get_text
    at accessiblegtkhex.c line 302
  • #4 ??
    from /usr/lib64/gtk-2.0/modules/libatk-bridge.so
  • #5 signal_emit_unlocked_R
    at gsignal.c line 2406
  • #6 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #7 IA__g_signal_emit_by_name
    at gsignal.c line 2267
  • #8 _accessible_gtk_hex_changed_cb
    at accessiblegtkhex.c line 482
  • #9 IA__g_closure_invoke
    at gclosure.c line 490
  • #10 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #11 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #12 IA__g_signal_emit_by_name
    at gsignal.c line 2267
  • #13 hex_document_real_changed
    at hex-document.c line 323
  • #14 IA__g_closure_invoke
    at gclosure.c line 490
  • #15 signal_emit_unlocked_R
    at gsignal.c line 2370
  • #16 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #17 IA__g_signal_emit
    at gsignal.c line 2243
  • #18 gtk_hex_key_press
    at gtkhex.c line 1618
  • #19 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #20 IA__g_closure_invoke
    at gclosure.c line 490
  • #21 signal_emit_unlocked_R
    at gsignal.c line 2478
  • #22 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #23 IA__g_signal_emit
    at gsignal.c line 2243
  • #24 gtk_widget_event_internal
    at gtkwidget.c line 4674
  • #25 IA__gtk_window_propagate_key_event
    at gtkwindow.c line 4930
  • #26 gtk_window_key_press_event
    at gtkwindow.c line 4960
  • #27 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #28 IA__g_closure_invoke
    at gclosure.c line 490
  • #29 signal_emit_unlocked_R
    at gsignal.c line 2478
  • #30 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #31 IA__g_signal_emit
    at gsignal.c line 2243
  • #32 gtk_widget_event_internal
    at gtkwidget.c line 4674
  • #33 IA__gtk_propagate_event
    at gtkmain.c line 2292
  • #34 IA__gtk_main_do_event
    at gtkmain.c line 1538
  • #35 gdk_event_dispatch
    at gdkevents-x11.c line 2352
  • #36 IA__g_main_context_dispatch
    at gmain.c line 2061
  • #37 g_main_context_iterate
    at gmain.c line 2694
  • #38 IA__g_main_loop_run
    at gmain.c line 2898 


Other information:
Comment 1 Stanislav Brabec 2007-09-03 15:28:53 UTC 
Created attachment 94866 [details] [review]
ghex-empty-search-crash.patch

g_locale_to_utf8 says nothing about accepting NULL as opsysstring. Attached patch fixes crash, but console output says ther it is not complete.

(ghex2:16739): Gtk-CRITICAL **: gtk_text_buffer_set_text: assertion `text != NULL' failed

(ghex2:16739): Gtk-CRITICAL **: gtk_text_buffer_emit_insert: assertion `g_utf8_validate (text, len, NULL)' failed
Comment 2 Rodney Dawes 2007-09-15 18:55:09 UTC 
Can you get freeze break approval for this today, so we can get the definite crash fix in for 2.20? If possible, it would be good to have the CRITICALs fixed as well. They will have to be fixed soon also, whether they are fixed now or not.
Please get freeze approval and commit the patch if it is approved.
Comment 3 Rodney Dawes 2007-09-17 18:00:29 UTC 
Any news on this Stanislav?
Comment 4 Stanislav Brabec 2007-09-18 13:27:05 UTC 
I did not yet researched on fixing Gtk-CRITICALs, but with the patch it at least does not crash.

I don't know the freeze approval workflow at all.
Comment 5 André Klapper 2007-12-21 10:37:06 UTC 
stanislav, can you please commit?
Comment 6 Rodney Dawes 2007-12-21 14:10:39 UTC 
The CRITICALs also need to be fixed. They will cause a crash in the development release of gnome by default. So, I'm going to change this to needs-work. Can we please get those fixed and get this patch in? Thanks.
Comment 7 Rodney Dawes 2008-01-30 16:59:02 UTC 
Stanislav, please fix the patch to resolve the CRITICALS as well.
Comment 8 André Klapper 2008-01-30 17:13:53 UTC 
(NEEDINFO means you need additional info from the reporter. this is not the case at all here.)
Comment 9 Rodney Dawes 2008-11-06 02:47:36 UTC 
*** Bug 532184 has been marked as a duplicate of this bug. ***
Comment 10 Dominique Leuenberger 2013-02-19 15:49:51 UTC 
Errr. is this actually still valid? I see the openSUSE package still carries this patch...
Comment 11 Stanislav Brabec 2013-02-19 16:08:30 UTC 
It seems that it is no more needed. It was fixed differently in upstream - search window always carries at least "0".