GNOME Bugzilla – Bug 472371
key F7 behavior
Last modified: 2007-09-06 11:14:17 UTC
Hi. Is this a new feature? F7 key is hiding the cursor. I used to have that key enabled by devhelp plugin, but since 2.19 version it hides the cursor. By pressing it again, the cursor is restored. (If i click on 'Show API Documentation' item under Tools menu, devhelp works as expected, so i guess this issue is not devhelp's fault)
I think this regression was introduced by the following patch to gtk+ 2007-05-18 Matthias Clasen <mclasen@redhat.com> * gtk/gtktextview.c: Add a toggle-cursor-visibility keybinding signal, and bind F7 to it. (#380048, Tim Miao)
Created attachment 94989 [details] [review] Proposed patch Needs confirmation from the docs guys
Created attachment 94991 [details] [review] Proposed patch, with doc changes This time i've changed the manual too.
2007-09-05 Jonh Wendell <jwendell@gnome.org> * plugins/spell/gedit-spell-plugin.c: Changed keybind from F7 to <Shift>F7, avoiding a conflict with gtk 2.12, fixes bug #472371.
Who approved this patch? Why it has been committed? Please revert and do not commit to gedit before the change has been approved. I do not agree that we should change the shortcut... that patch to gtk sucks and has to be fixed instead.
I sent a message to release-team: http://mail.gnome.org/archives/release-team/2007-September/msg00031.html And i chatted with paolo on irc about that. But if you still want, i can revert the commit for you.
Sorry if I sounded a bit upset, if Paolo blessed the change on irc then ok (maybe next time you can mention that in bugzilla). Personally I do not like at all that we have to change the shortcut and I also hate the fact that a newwer version of gtk steals very common keybindings like F7 (which is also used in the devhelp plugin for instance), but it's not your fault, so no need to revert.
I approved the patch by John on IRC. pbor: I agree with you that the gtk+ patch sucks, but: - it is a keybinding so, AFAIK, there is no way to make it work only when the text view is in a given state (as we discussed a few days ago) - they introduced it on may, so it is a bit late for us to complain (as we said we should try to track all the changes introduced in GtkTextView and friends). Sorry for the misunderstanding with you and John.
Thanks, guys. So, i'm closing this again, ok?