After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471757 - Codegen is using a pygtk private definition
Codegen is using a pygtk private definition
Status: RESOLVED OBSOLETE
Product: pygobject
Classification: Bindings
Component: codegen
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: Gian Mario Tagliaretti
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-30 08:17 UTC by Gian Mario Tagliaretti
Modified: 2012-02-10 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region patch (1.17 KB, patch)
2008-05-03 13:39 UTC, Gian Mario Tagliaretti
none Details | Review

Description Gian Mario Tagliaretti 2007-08-30 08:17:16 UTC
For methods that return a pointer to a GdkRegion codegen is using PYGDK_TYPE_REGION which is defined in pygtk-private.h, 

class GdkRegionPtrReturn(GBoxedReturn):
    def write_error_return(self):
        self.wrapper.write_code("return gdk_region_new();")
    def write_conversion(self):
        self.props['typecode'] = 'PYGDK_TYPE_REGION'
        self.props['typename'] = 'GdkRegion'
        super(GdkRegionPtrReturn, self).write_conversion()

argtypes.matcher.register_reverse_ret("GdkRegion*", GdkRegionPtrReturn)

Will it be safe to move it from pygtk-private.h into pygtk.h?
Maybe a patch for GTK+ to make it boxed?
Comment 1 Gustavo Carneiro 2007-08-30 11:00:37 UTC
A patch for GTK+ would be nice.

And I guess moving it to pygtk.h would not be a bad idea; right now 3rd party extensions that encounter GdkRegion* return in virtuals will probably not compile because PYGDK_TYPE_REGION isn't defined.  Although defining PYGDK_TYPE_REGION in pygtk.h _right now_ is not possible because of API freeze.
Comment 2 Gian Mario Tagliaretti 2008-05-03 13:39:32 UTC
Created attachment 110320 [details] [review]
region patch
Comment 3 Martin Pitt 2012-02-10 08:10:26 UTC
codegen and the static bindings are obsolete since pygobject 3.0, which is GI only.

Thanks!