After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471610 - [ivorbis] does not support 16-bit width
[ivorbis] does not support 16-bit width
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-29 23:21 UTC by Joni Valtanen
Modified: 2009-09-10 08:20 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch to support 16-bit width (4.56 KB, patch)
2007-08-29 23:28 UTC, Joni Valtanen
needs-work Details | Review

Description Joni Valtanen 2007-08-29 23:21:39 UTC
Ivorbis does not support 16-bit width. Only 32-bit is supported. It would be nice to link to audiosink without using audioconvert. Especially with handhelds and other similar devices.
Comment 1 Joni Valtanen 2007-08-29 23:28:49 UTC
Created attachment 94586 [details] [review]
Patch to support 16-bit width

This is easy to test with gst-launch.

16:
gst-launch-0.10 -v filesrc location=/your/favorite/ogg ! oggdemux ! ivorbisdec ! alsasink

32:
gst-launch-0.10 -v filesrc location=/your/favorite/ogg ! oggdemux ! ivorbisdec ! audioconvert ! alsasink


There were some problems with svn version of Tremor also but checking that following lines are in the file called Version_script.in

.....

vorbis_block_init;
vorbis_block_clear;
vorbis_synthesis_init;
vorbis_synthesis_blockin;
vorbis_synthesis_headerin;
vorbis_synthesis_pcmout;
vorbis_synthesis_read;
vorbis_synthesis;
vorbis_book_init_decode;
vorbis_dsp_clear;
vorbis_info_init;
vorbis_info_clear;
vorbis_info_blocksize;
vorbis_comment_init;
vorbis_comment_add;
vorbis_comment_add_tag;
vorbis_comment_query;
vorbis_comment_query_count;
vorbis_comment_clear;

.....
Comment 2 Sebastian Dröge (slomo) 2009-05-07 11:07:02 UTC
This patch is not correct as _get_allowed_caps() can return unfixed caps, i.e. width could be "{ 16, 32 }". This should be handled by gst_structure_field_fixate_nearested_int() or similar.
Comment 3 Sebastian Dröge (slomo) 2009-09-10 08:20:39 UTC
Is this still wanted to be added to ivorbis? Please reopen in that case...