After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471583 - Does not block https:// adverts
Does not block https:// adverts
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] Backend:Mozilla
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-29 22:29 UTC by Sven Arvidsson
Modified: 2007-09-27 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Treat https URLs just like http ones (893 bytes, patch)
2007-09-26 22:38 UTC, Josselin Mouette 		committed Details | Review

Description Sven Arvidsson 2007-08-29 22:29:29 UTC 
[ From http://bugs.debian.org/439772 by Neil Williams ]

"Ads blocked when viewing a page over http:// are not blocked when viewing the same page over https:// and there appears to be no way to tweak the rule to block https:// adverts.

e.g. with this rule:
$ cat ~/.gnome2/epiphany/extensions/data/adblock/blacklist
ad\.doubleclick\.net/

http://sourceforge.net/projects/pilot-qof
https://sourceforge.net/projects/pilot-qof"
Comment 1 Christian Persch 2007-08-30 18:51:18 UTC 
-> Epiphany

embed/mozilla/EphyContentPolicy.cpp just always allows loading if the page is https://.
Comment 2 Josselin Mouette 2007-09-26 22:38:42 UTC 
Created attachment 96263 [details] [review]
Treat https URLs just like http ones

With this patch, https is filtered just like http. Do you think this is the correct approach?
Comment 3 Christian Persch 2007-09-27 12:12:50 UTC 
The patch looks correct. I wonder why I made https always pass in the first place...

oktc (trunk and 2-20)
Comment 4 Josselin Mouette 2007-09-27 12:45:44 UTC 
Committed to trunk (r7498) and 2-20 (r7499).
Comment 5 Cosimo Cecchi 2007-09-27 15:53:06 UTC 
Thanks Josselin, closing as FIXED then.