GNOME Bugzilla – Bug 470404
Usage of non-tango yelp-icon-big
Last modified: 2007-09-05 20:03:59 UTC
Currently Yelp ships a 192x192 bitmap icon named yelp-icon-big, which is not in tango style. I tried to fix this by using the gnome-help icon, but didn't really understand how the icon is being used (how it gets from the theme to the HTML page) We have the new tangoish Yelp icon available as an SVG in gnome-icon-theme, but I guess Yelp needs a bitmap here?
The icon is used on the table of contents of yelp (when you first start it up), in the left column of categories, as a background image. That's the only place it's used. It's found in src/yelp-toc.c, around line 779 using gtk_icon_theme_lookup_icon at a size of 192x192. What's the best way to handle this? I tried using this directly, but something in gecko borks on it / the way I'm using it (resulting in no image) :( We could do a direct replacement of the file if that's acceptable. Or putting a 192x192 image in gnome-icon-theme? I'm inclined to just do a copy the new icon into the yelp package, unless there's an objection.
I guess the best way would be to render a big bitmap from the SVG and put it into the yelp package... and the icon should probably not be installed in hicolor, but a private icon directory, see http://live.gnome.org/ThemableAppSpecificIcons
Created attachment 94949 [details] New Icon This is the new icon. I've requested a UI break to put this into the yelp package for 2.20. With this, I'll make the relevent changes and install in the correct place.
Icon changed in SVN. I've left the icon as public for now as it is the same icon as the "app" icon. If people want to use the 192x192 version, it's up to them. If you disagree strongly, please leave an explanation and I'll reconsider. For now though, marking as Fixed. 2007-09-05 Don Scorgie <dscorgie@svn.gnome.org> * data/icons/yelp-icon-big.png: New tango-ified version
Is there a need to call the icon "yelp-icon-big" instead of just "yelp"?