After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 470037 - include "../libtracker/tracker.h" instead of <tracker.h>
include "../libtracker/tracker.h" instead of <tracker.h>
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Jamie McCracken
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2007-08-24 21:18 UTC by Yuri Pankov
Modified: 2007-09-07 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change the order of INCLUDES. (358 bytes, patch)
2007-08-26 00:41 UTC, Jeremy Messenger
none Details | Review
one more that need to be reorder. (723 bytes, patch)
2007-08-26 21:19 UTC, Jeremy Messenger
none Details | Review

Description Yuri Pankov 2007-08-24 21:18:55 UTC
I'm looking at http://svn.gnome.org/viewcvs/tracker/trunk/src/libtracker-gtk/tracker-keyword-store.h?r1=504&r2=531

This change makes it impossible to upgrade to 0.6.1 from 0.5.4, can it be reverted?

src/libtracker-gtk/tracker-keyword-store.h
src/libtracker-gtk/tracker-metadata-tile.h
src/libtracker-gtk/tracker-utils.h

should also include bundled tracker.h and not system wide (which can be too old for upgrade to succeed)

Thanks in advance.
Comment 1 Jeremy Messenger 2007-08-26 00:41:04 UTC
Created attachment 94339 [details] [review]
Change the order of INCLUDES.

Attaching a patch, I think it is better to patch in src/libtracker-gtk/Makefile.am instead of poke around with the path of include for tracker.h.

The problem is that the freetype2.pc has -I${includedir}, so the 'pkg-config --cflags freetype2' looks like this:

# pkg-config --cflags freetype2
-I/usr/local/include/freetype2 -I/usr/local/include

That -I/usr/local/include went in $(LIBTRACKERGTK_CFLAGS) that avoid users to upgrade the tracker.
Comment 2 Jeremy Messenger 2007-08-26 21:19:26 UTC
Created attachment 94396 [details] [review]
one more that need to be reorder.

The src/tracker-search-tool/Makefile.am also need to be reorder to fix the build problem.
Comment 3 Jamie McCracken 2007-09-07 12:34:58 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.