GNOME Bugzilla – Bug 469407
Emblem icon work
Last modified: 2008-06-15 02:31:12 UTC
Now that nautilus reworked the emblem displaying code depending on the right emblem size, it would be nice to have the emblems in g-i-t fixed before GNOME 2.20 is released. There's a very nice coverage already, but there are some old emblems that are currently only available in the old 48x48 size: - emblem-art: this could be useful, tango version for all sizes would be nice... perhaps we could even use the graphics category icon here? - emblem-camera: we already have emblem-photos, so this could be removed? - emblem-certified: I don't see the use of this, remove? - emblem-cool: could also be useful... but we already have emblem-favorite - emblem-danger: we already have emblem-urgent and emblem-important and the HIG discourages usage of weapons in icons... remove! - emblem-desktop: still used by nautilus? anyway, we have the desktop icon, let's use this here, too - emblem-distinguished: not needed, remove - emblem-draft: not needed, remove - emblem-handshake: not needed, remove - emblem-marketing: not needed, remove - emblem-money: not needed, remove - emblem-multimedia: this actually looks like a film roll... so let's do a tango emblem-video. re-use the mime type icon? - emblem-note: used by nautilus! take the tomboy note sheet and add a pin? - emblem-ohno: I see no use for this - emblem-OK: no use again... - emblem-people: can also be removed. - emblem-pictures: we have emblem-photos now - emblem-plan: huh? remove - emblem-presentation: remove - emblem-sales remove - emblem-sound: in addition to emblem-video, let's have an emblem-audio. re-use the mime type icon? - emblem-trash: no use, remove Also, there is emblem-special in scalable/, would be nice to have such a generic "marker" emblem for all sizes, in tango style. With those useless emblems removed, the emblem setting UIs are much more fun to use and the emblems that remain look great in the various sizes. [1]http://svn.gnome.org/viewcvs/nautilus/trunk/ChangeLog?revision=13100&view=markup
I dived into the nautilus source code and found that "emblem-trash" seems to be used internally somehow, so it also need a tango makeover... So here is a TODO list: Redo: emblem-art, emblem-desktop, emblem-note, emblem-trash, emblem-special New: emblem-audio, emblem-video Remove: emblem-camera, emblem-certified, emblem-cool, emblem-danger, emblem-distinguished, emblem-draft, emblem-handshake, emblem-marketing, emblem-multimedia, emblem-money, emblem-ohno, emblem-OK, emblem-people, emblem-pictures, emblem-plan, emblem-presentation, emblem-sales, emblem-sound If this stuff is cleaned up, we can start adding .icon files for each of the remaining emblems.
Why is emblem-desktop needed? There is a user-desktop icon in the places context. There is no need to use a folder+emblem for this. Thunar already uses the icon appropriately.
Jakub, see libnautilus-private/nautilus-emblem-utils.c, you'll find #define EMBLEM_NAME_DESKTOP "emblem-desktop" Nautilus uses this icon internally, it sets the emblem automatically for the ~/Desktop folder. So this is needed as long as nautilus isn't changed. Naturally, we could open a bug against nautilus to use the icon in places/... Are you ok with removing the other emblems?
I filed a bug against nautilus (#470381), with a patch to use user-desktop and user-trash instead of emblem-desktop and emblem-trash.
I am actually fine with removing all the emblems mentioned. Having a limited number of emblems that people can use to attach to their folder and files is a half-arsed solution. You can't search for them, there will always be emblems that people would like to use and they will not be there as well as emblems that will be there and people will not use them. Tags are a lot more useful for this kind of functionality, and we should stick with core emblems defined by the names spec which are attached to items automatically by the system to illustrate some property (read-only, link, etc). I wish to remove them all, but it's hard for me to find out what depends on them. So my solution would be to wait with the removal until after 2.20 and then remove them early on in the cycle.
Jakub, these are the emblems nautilus depends on (straight from the source): #define EMBLEM_NAME_TRASH "emblem-trash" #define EMBLEM_NAME_SYMLINK "emblem-symbolic-link" #define EMBLEM_NAME_NOREAD "emblem-noread" #define EMBLEM_NAME_NOWRITE "emblem-nowrite" #define EMBLEM_NAME_NOTE "emblem-note" #define EMBLEM_NAME_DESKTOP "emblem-desktop" As I already wrote, I submitted patches to use user-desktop and user-trash. The rest of the emblems do not have any dependants, at least not nautilus.
Argh, forget to say what I wanted to say in the first place: while removing early for 2.22 is fine, keep ind mind that most of the emblems will look quite a bit more broken than they used to look like. I would remove them now and fix up the .icon files for the visible emblems, I think this would be safe to do.
Started a discussion on usability-list: http://mail.gnome.org/archives/usability/2008-April/msg00010.html
I've removed almost all of the emblems now. ALl the old 48x48/emblems are gone. There are still some leftover emblems in the new style that should be removed later though, such as emblem-desktop. For the photos/art/etc... emblems, I believe the best solution is to separate them from emblems, and call them tags. This will result in the following: Tags == set by user (music, shakespeare, toga party, whatever...) Emblems == set by system (filesystem properties, sharing, etc...) This will allow us to provide a fully usable theme, with some nice default tag icons, without munging the two concepts into one, and allows the user to customize their tags. Some of the tag icons can probably just be dropped entirely, and provided as user folder icons, to match the xdg user directories spec (Audio, Video, Pictures, etc...).