GNOME Bugzilla – Bug 468762
Orca does not speak unexpanded combo boxes in Pidgin preferences dialog
Last modified: 2008-01-08 16:21:07 UTC
Steps to reproduce: 1. Launch Pidgin 2. Get into the Preferences dialog 3. Tab to a combo box Expected results: Orca would speak the currently selected item in the combo box. Actual results: Orca doesn't speak the currently selected item in the combo box until you expand the combo box by pressing space bar.
Created attachment 94060 [details] Gzipped Orca debug.out from testing the pidgin problem.
Created attachment 94061 [details] Gzipped Orca debug.out from bringing up the Orca preferences dialog. Added two attachments: 1/ Orca debug.out from running pidgin, bringing up the Preferences dialog and tabbing to a combo box. 2/ Orca debug.out from bringing up the Orca Preferences dialog and Tabbing to the "Say all" combo box on the speech pane. This correctly speaks the current combo box selection. In the first case, we are processing the combo box as the result of getting an "object:state-changed:focused" event (see about line 3077). In the second case, we are processing the combo box as a result of getting a "focus:" event (see about line 14278). Presumably there is a subtle difference in the way these two events are handled. Investigating further.
If I compare the pidgin combo box against one of the ones on the Orca Preferences dialog, I see that they are going through different paths in the __getDisplayedTextInComboBox() routine in defauly.py. Detailed debug output below, but in short, the problem is caused because the pidgen combo box returns None when you look at combo.selection (about line 4688): ... else: selectedItem = None comboSelection = combo.selection <=== RETURNS NONE if comboSelection and comboSelection.nSelectedChildren > 0: ... ======== pidgen Preferences - Show system tray icon combo box ======== getDisplayedText CALLED. combo.childCount: 1 child[0]: role: menu textObj: None obj.role: combo box comboSelection: None NAME Show system tray icon: [1] name: Show system tray icon: returning name: Show system tray icon: name: ['Show system tray icon:'] getting speech for role: ['combo box'] getting speech for availability: [] ['Show system tray icon: combo box'] _getSpeechForComboBox called: already_focused: False getDisplayedText CALLED. label: ['Show system tray icon:'] _getSpeechForObjectName called. getDisplayedText CALLED. combo.childCount: 1 child[0]: role: menu textObj: None obj.role: combo box comboSelection: None NAME Show system tray icon: [1] name: Show system tray icon: returning name: Show system tray icon: name: ['Show system tray icon:'] getting speech for role: ['combo box'] getting speech for availability: [] SPEECH OUTPUT: 'Interface page System Tray Icon' SPEECH OUTPUT: 'Show system tray icon: combo box' ======= Orca Preferences dialog - speech pane - Say all by combo box ======== getDisplayedText CALLED. combo.childCount: 1 child[0]: role: menu textObj: None obj.role: combo box comboSelection: <CORBA.Object 'IDL:Accessibility/Selection:1.0' at 0x15a9680> nSelectedChildren: 1 selectedItem: <orca.atspi.Accessible instance at 0x1762440> getDisplayedText CALLED. SELECTEDITEM Sentence [1] name: Sentence returning name: Sentence name: ['Sentence'] getting speech for role: ['combo box'] getting speech for availability: [] SPEECH OUTPUT: 'Speech page' SPEECH OUTPUT: 'Say All By: Sentence combo box'
To expand on this further, using accersizer, I was able to see that the pidgin "Show system tray icon" combo box contains a menu which has three menu items in it. That menu implements "selection", not the combo box. Unfortunately I can't do a similar comparison on the "Say all" combo box on the speech pane of the orca preferences dialog, as accersizer crashes.
pidgin uses it's own custom widget for combo boxes. In pidgin 2.1.1, in .../pidgin-2.1.1/pidgin/gtkprefs.c there is: ... label = pidgin_prefs_dropdown(vbox, _("_Show system tray icon:"), PURPLE_PREF_STRING, PIDGIN_PREFS_ROOT "/docklet/show", _("Always"), "always", _("Never"), "never", _("On unread messages"), "pending", NULL); ... about line 894. The pidgin_prefs_dropdown() routine is at line 302 and ends up calling pidgin_prefs_dropdown_from_list() (at line 202). Inside that routine there is a chunk of code: ... #if 0 /* GTK_CHECK_VERSION(2,4,0) */ if(type == PURPLE_PREF_INT) model = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_INT); else if(type == PURPLE_PREF_STRING) model = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_STRING); dropdown = gtk_combo_box_new_with_model(model); #else dropdown = gtk_option_menu_new(); menu = gtk_menu_new(); #endif ... If I'm reading that correctly then pidgin is now using gtk_option_...() rather than gtk_combo_...() And it would appear not to do the right thing. Adding Irene to the cc:. Irene, I understand from Will Walker that you are familiar with the pidgin code. Have you any comments on the problem we are seeing here? Thanks.
Created attachment 94072 [details] Simple example using gtk_option_...() I found a simple C code example that calls gtk_option_...() calls. Orca has no problem speaking the currently selected option entry. This suggests that the pidgin folks have something wrong that's specific to their application. Perhaps it's time to fix YAPB? ...
I think I might have been missing the obvious here. In pidgin, for the object:state-changed:focused event we have: OBJECT EVENT: object:state-changed:focused detail=(1,0) app.name='pidgin' name='Show system tray icon:' role='combo box' state='ENABLED FOCUSABLE FOCUSED SENSITIVE SHOWING VISIBLE' relations='LABELLED_BY LABELLED_BY' In Orca, for the "focus:" event for the Say all combo box, we have: OBJECT EVENT: focus: detail=(0,0) app.name='orca' name='Sentence' role='combo box' state='ENABLED FOCUSED SENSITIVE SHOWING VISIBLE' relations='LABELLED_BY' In other words, the name of the pidgin "combo box" is incorrect.
Yup, that was it: In pidgin gtkprefs.c, there is the call to pidgin_prefs_dropdown_from_list() label = pidgin_prefs_dropdown(vbox, _("_Show system tray icon:"), PURPLE_PREF_STRING, PIDGIN_PREFS_ROOT "/docklet/show", _("Always"), "always", _("Never"), "never", _("On unread messages"), "pending", NULL); Function definition for pidgin_prefs_dropdown_from_list() is: pidgin_prefs_dropdown_from_list(GtkWidget *box, const gchar *title, PurplePrefType type, const char *key, GList *menuitems) so we are passing in a title variable of _("_Show system tray icon:"). We then go through this bit of code: ... if (title != NULL) { hbox = gtk_hbox_new(FALSE, 5); /*gtk_container_add (GTK_CONTAINER (box), hbox);*/ gtk_box_pack_start(GTK_BOX(box), hbox, FALSE, FALSE, 0); gtk_widget_show(hbox); label = gtk_label_new_with_mnemonic(title); gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, FALSE, 0); gtk_widget_show(label); } else { ... which sets the label to the left of the "combo box". It also sets the variable called label. Further down the routine we have: ... if (label != NULL) { gtk_label_set_mnemonic_widget(GTK_LABEL(label), dropdown); pidgin_set_accessible_label (dropdown, label); } ... which is setting the accessible "label" of the dropdown widget (which was created with: dropdown = gtk_option_menu_new(); to "_Show system tray icon:". (See pidgin_set_accessible_label() in gtkutils.c at about line 1168). Oops! I'll file a pidgin bug and block this one.
Ah, the joys of open source development. I need to register on yet another system in order to report a bug in their application. When I try to do, I get: Server Overloaded The Pidgin Trac instance has encountered an error related to the high load on the server. There is no need to report this issue. If you would like to donate a server or otherwise help to resolve this, please let us know. TracGuide — The Trac User and Administration Guide Python Traceback Traceback (most recent call last):
+ Trace 156960
dispatcher.dispatch(req)
resp = chosen_handler.process_request(req)
return DatabaseManager(self).get_connection()
return self._cnx_pool.get_cnx(self.timeout or None)
raise TimeoutError('Unable to get database '
I wonder where I need to register in order to file a bug on that? Sigh.
There bug reporting system is yet another wiki. How novel is that! Here's the ticket URL: http://developer.pidgin.im/ticket/2687#preview Don't forget to register and login if you want to add a comment.
I should add that all the combo boxes on the pidgin Preferences dialog have a similar problem. In other words, I believe the fix is going to be in pidgin_prefs_dropdown_from_list(), and you don't want to call: pidgin_set_accessible_label (dropdown, label); I added a comment to the pidgin ticket on this.
Thanks for the thorough report. This should be fixed for combo boxes in the prefs window. As for registering on yet another bug tracking system, I hear ya!
Thanks for the quick fix Casey!
(In reply to comment #12) > Thanks for the thorough report. This should be fixed for combo boxes in the > prefs window. > > As for registering on yet another bug tracking system, I hear ya! > The pidgin source tarball download is stalling for me, so I cannot verify the fix. But, the blocking bug has been marked fixed, so I'm unblocking this one.
I'm not able to successfully run the latest pidgin. Here's what I've done: 1/ Downloaded latest pidgin tarball from http://downloads.sourceforge.net/pidgin/pidgin-2.3.1.tar.bz2 2/ Unpacked, configured, built and installed it with: $ bunzip2 pidgin-2.3.1.tar.bz2 $ tar -xvf pidgin-2.3.1.tar $ cd pidgin-2.3.1 $ ./configure --prefix=/usr $ make $ sudo make install 3/ Ran it (with debug command line option): $ pidgin -d (12:25:06) prefs: Reading /home/richb/.purple/prefs.xml (12:25:06) prefs: Finished reading /home/richb/.purple/prefs.xml (12:25:06) dbus: okkk (12:25:06) plugins: probing /usr/lib/pidgin/gevolution.so (12:25:06) plugins: probing /usr/lib/pidgin/gestures.so (12:25:06) plugins: probing /usr/lib/pidgin/musicmessaging.so (12:25:06) plugins: probing /usr/lib/pidgin/ticker.so (12:25:06) plugins: probing /usr/lib/pidgin/convcolors.so (12:25:06) plugins: probing /usr/lib/pidgin/extplacement.so (12:25:06) plugins: probing /usr/lib/pidgin/gtkbuddynote.so (12:25:06) plugins: probing /usr/lib/pidgin/history.so (12:25:06) plugins: probing /usr/lib/pidgin/iconaway.so (12:25:06) plugins: probing /usr/lib/pidgin/markerline.so (12:25:06) plugins: probing /usr/lib/pidgin/notify.so (12:25:06) plugins: probing /usr/lib/pidgin/pidginrc.so (12:25:06) plugins: probing /usr/lib/pidgin/spellchk.so (12:25:06) plugins: probing /usr/lib/pidgin/timestamp.so (12:25:06) plugins: probing /usr/lib/pidgin/timestamp_format.so (12:25:06) plugins: probing /usr/lib/pidgin/xmppconsole.so (12:25:06) plugins: probing /usr/lib/pidgin/cap.so (12:25:06) plugins: probing /usr/lib/pidgin/relnot.so (12:25:06) plugins: probing /usr/lib/purple-2/ssl-gnutls.so (12:25:06) plugins: probing /usr/lib/purple-2/perl.so (12:25:06) plugins: probing /usr/lib/purple-2/ssl.so (12:25:06) plugins: probing /usr/lib/purple-2/autoaccept.so (12:25:06) plugins: probing /usr/lib/purple-2/ssl-nss.so (12:25:06) plugins: probing /usr/lib/purple-2/tcl.so (12:25:06) plugins: probing /usr/lib/purple-2/buddynote.so (12:25:06) plugins: probing /usr/lib/purple-2/idle.so (12:25:06) plugins: probing /usr/lib/purple-2/joinpart.so (12:25:06) plugins: probing /usr/lib/purple-2/log_reader.so (12:25:06) plugins: probing /usr/lib/purple-2/newline.so (12:25:06) plugins: probing /usr/lib/purple-2/offlinemsg.so (12:25:06) plugins: probing /usr/lib/purple-2/psychic.so (12:25:06) plugins: probing /usr/lib/purple-2/statenotify.so (12:25:06) plugins: probing /usr/lib/purple-2/dbus-example.so (12:25:06) plugins: probing /usr/lib/purple-2/libbonjour.so (12:25:06) plugins: probing /usr/lib/purple-2/libgg.so (12:25:06) plugins: probing /usr/lib/purple-2/libirc.so (12:25:06) plugins: probing /usr/lib/purple-2/libnovell.so (12:25:06) plugins: probing /usr/lib/purple-2/libxmpp.so (12:25:06) util: Reading file xmpp-caps.xml from directory /home/richb/.purple (12:25:06) util: File /home/richb/.purple/xmpp-caps.xml does not exist (this is not necessarily an error) (12:25:06) plugins: probing /usr/lib/purple-2/libmsn.so (12:25:06) plugins: probing /usr/lib/purple-2/libaim.so (12:25:06) plugins: probing /usr/lib/purple-2/libicq.so (12:25:06) plugins: probing /usr/lib/purple-2/libqq.so (12:25:06) plugins: probing /usr/lib/purple-2/libsametime.so (12:25:06) plugins: /usr/lib/purple-2/libsametime.so has a prefs_info, but is a prpl. This is no longer supported. (12:25:06) plugins: probing /usr/lib/purple-2/libsimple.so (12:25:06) plugins: probing /usr/lib/purple-2/libyahoo.so (12:25:06) plugins: probing /usr/lib/purple-2/libzephyr.so (12:25:06) plugins: probing /usr/lib/purple-2/libjabber.so (12:25:06) plugins: /usr/lib/purple-2/libjabber.so is not usable because the 'purple_init_plugin' symbol could not be found. Does the plugin call the PURPLE_INIT_PLUGIN() macro? (12:25:06) plugins: probing /usr/lib/purple-2/liboscar.so (12:25:06) plugins: /usr/lib/purple-2/liboscar.so is not usable because the 'purple_init_plugin' symbol could not be found. Does the plugin call the PURPLE_INIT_PLUGIN() macro? (12:25:06) plugins: probing /usr/lib/purple-2/libmyspace.so (12:25:06) prefs: /purple/status/scores/offline changed, scheduling save. (12:25:06) prefs: /purple/status/scores/available changed, scheduling save. (12:25:06) prefs: /purple/status/scores/invisible changed, scheduling save. (12:25:06) prefs: /purple/status/scores/away changed, scheduling save. (12:25:06) prefs: /purple/status/scores/extended_away changed, scheduling save. (12:25:06) prefs: /purple/status/scores/idle changed, scheduling save. (12:25:06) prefs: /purple/status/scores/offline_msg changed, scheduling save. (12:25:06) util: Reading file accounts.xml from directory /home/richb/.purple (12:25:06) dbus: Need to register an object with the dbus subsystem. (If you are not a developer, please ignore this message.) (12:25:06) dbus: The signal "account-error-changed" caused some dbus error. (If you are not a developer, please ignore this message.) (12:25:06) util: Reading file status.xml from directory /home/richb/.purple (12:25:06) certificate: CertificateVerifier x509, singleuse requested but not found. (12:25:06) certificate: CertificateVerifier singleuse registered (12:25:06) certificate: CertificatePool x509, ca requested but not found. (12:25:06) certificate: CertificateScheme x509 requested but not found. (12:25:06) certificate/x509/ca: Lazy init failed because an X.509 Scheme is not yet registered. Maybe it will be better later. (12:25:06) certificate/x509/ca: Init failed, probably because a dependency is not yet registered. It has been deferred to later. (12:25:06) certificate: CertificatePool ca registered (12:25:06) certificate: CertificatePool x509, tls_peers requested but not found. (12:25:06) certificate: CertificatePool tls_peers registered (12:25:06) certificate: CertificateVerifier x509, tls_cached requested but not found. (12:25:06) certificate: CertificateVerifier tls_cached registered (12:25:06) prefs: /purple/logging/format changed, scheduling save. (12:25:06) prefs: /purple/logging/format changed, scheduling save. (12:25:06) prefs: /purple/proxy/type changed, scheduling save. (12:25:06) prefs: /purple/proxy/host changed, scheduling save. (12:25:06) prefs: /purple/proxy/port changed, scheduling save. (12:25:06) prefs: /purple/proxy/username changed, scheduling save. (12:25:06) prefs: /purple/proxy/password changed, scheduling save. (12:25:06) certificate: CertificateScheme x509 requested but not found. (12:25:06) certificate: CertificateScheme x509 registered (12:25:06) stun: using server (12:25:06) sound: Initializing sound output drivers. (12:25:06) prefs: /pidgin/conversations/placement changed, scheduling save. (12:25:06) prefs: purple_prefs_connect_callback: Unknown pref /pidgin/conversations/im/show_protocol_icons (12:25:06) gtkblist: added visibility manager: 1 (12:25:06) docklet: created (12:25:06) main: exiting because another libpurple client is already running (12:25:06) blist: Attempted to save buddy list before it was read! (12:25:06) certificate: CertificateScheme x509 unregistered (12:25:06) certificate: CertificateVerifier tls_cached unregistered (12:25:06) certificate: CertificateVerifier singleuse unregistered (12:25:06) certificate: CertificatePool tls_peers unregistered (12:25:06) certificate: CertificatePool ca unregistered (12:25:06) util: Writing file accounts.xml to directory /home/richb/.purple (12:25:06) util: Writing file /home/richb/.purple/accounts.xml (12:25:07) util: Writing file prefs.xml to directory /home/richb/.purple (12:25:07) util: Writing file /home/richb/.purple/prefs.xml (12:25:07) main: Unloading all plugins (12:25:07) plugins: Unloading plugin GNUTLS (12:25:07) certificate: CertificateScheme x509 unregistered (12:25:07) plugins: Unloading plugin Perl Plugin Loader (12:25:07) plugins: Unloading plugin SSL (12:25:07) plugins: Unloading plugin Tcl Plugin Loader (12:25:07) plugins: Unloading plugin Bonjour (12:25:07) plugins: Unloading plugin Gadu-Gadu (12:25:07) plugins: Unloading plugin IRC (12:25:07) plugins: Unloading plugin GroupWise (12:25:07) plugins: Unloading plugin XMPP (12:25:07) plugins: Unloading plugin MSN (12:25:07) plugins: Unloading plugin AIM (12:25:07) plugins: Unloading plugin ICQ (12:25:07) plugins: Unloading plugin QQ (12:25:07) plugins: Unloading plugin Sametime (12:25:07) plugins: Unloading plugin SIMPLE (12:25:07) plugins: Unloading plugin Yahoo (12:25:07) plugins: Unloading plugin Zephyr (12:25:07) plugins: Unloading plugin MySpaceIM (12:25:07) accels: accel changed, scheduling save. (12:25:07) accels: accel changed, scheduling save. (12:25:07) accels: accel changed, scheduling save. (12:25:07) accels: accel changed, scheduling save. (12:25:07) accels: accel changed, scheduling save. (12:25:07) accels: accel changed, scheduling save. (12:25:07) gtkblist: removed visibility manager: 0 (12:25:07) docklet: destroyed (12:25:07) Gtk: gtk_main_quit: assertion `main_loops != NULL' failed What am I missing or doing wrong?
I just built 2.3.1 from source in Hardy. I can confirm this bug is fixed.
(In reply to comment #16) > I just built 2.3.1 from source in Hardy. I can confirm this bug is fixed. > I'll take your word for it -- I cannot even get it to build on Solaris. :-) Thanks for testing this. Rich, feel free to close.
Okay, closing as FIXED. Joanie, I don't like an unsolved mystery so I'm curious to know if you did anything different. Any command line options to configure (apart from --prefix)? Did you have to reboot after you'd built pidgin? No biggie (and luckily I tried this on another machine then my Ferrari so I'm not IM-hosed at the moment), but I would like to get to the bottom of why mine didn't run. Thanks.
Nope, nothin' different and I did not have to reboot. Sorry! Missing dependency perhaps? You mentioned that you couldn't build gnome-mag on gutsy either (building it is hosed on hardy atm, but not gutsy last time I checked). Is there any chance that something larger is broken/missing/different on your system?
> You mentioned that you couldn't build gnome-mag on gutsy either (building it is > hosed on hardy atm, but not gutsy last time I checked). Is there any chance > that something larger is broken/missing/different on your system? Could be. Note that (for the record) I was trying to build gnome-mag on a different system than pidgin (on my Ferrari machine). They could certainly both be missing build dependancies though. Oh wait, shouldn't the configure scripts for those applications detect that? ;-)
Well pidgin is working just fine for me now. I suspect it was always working fine but, because it wasn't initially displaying the Buddy list window I didn't realize it was running. An IM message from Joanie appeared and I then noticed the icon in the gnome-panel. Anyhoo, I can confirm that the bug has indeed been fixed. ... SPEECH OUTPUT: '' SPEECH OUTPUT: 'Preferences button' BRAILLE LINE: 'pidgin Application Preferences Frame' VISIBLE: 'Preferences Frame', cursor=1 SPEECH OUTPUT: 'Preferences frame' BRAILLE LINE: 'pidgin Application Preferences Frame Interface Page' VISIBLE: 'Interface Page', cursor=1 SPEECH OUTPUT: '' SPEECH OUTPUT: 'Interface page' SPEECH OUTPUT: 'Tab' BRAILLE LINE: 'pidgin Application Preferences Frame TabList Interface Page System Tray Icon System Tray Icon Filler Show system tray icon: Always Combo' VISIBLE: 'Always Combo', cursor=1 SPEECH OUTPUT: 'System Tray Icon' SPEECH OUTPUT: 'Show system tray icon: Always combo box' SPEECH OUTPUT: 'Tab' BRAILLE LINE: 'pidgin Application Preferences Frame TabList Interface Page Conversation Window Hiding Conversation Window Hiding Filler Hide new IM conversations: Never Combo' VISIBLE: 'Never Combo', cursor=1 SPEECH OUTPUT: 'Conversation Window Hiding' SPEECH OUTPUT: 'Hide new IM conversations: Never combo box' ...