After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 468129 - [basertpaudiopayload] event handler returns the wrong value
[basertpaudiopayload] event handler returns the wrong value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 469322 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-19 06:29 UTC by Olivier Crête
Modified: 2007-09-05 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple patch to return false instead of true (841 bytes, patch)
2007-08-19 06:30 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2007-08-19 06:29:59 UTC 
The event handler in GstBaseRTPAudioPayload returns TRUE stopping events, but it should return FALSE so that the default handler is called.
Comment 1 Olivier Crête 2007-08-19 06:30:35 UTC 
Created attachment 93926 [details] [review]
simple patch to return false instead of true
Comment 2 Tim-Philipp Müller 2007-08-23 08:48:43 UTC 
*** Bug 469322 has been marked as a duplicate of this bug. ***
Comment 3 Tim-Philipp Müller 2007-09-05 15:56:39 UTC 
This has been fixed now, it seems, thanks!

 2007-09-04  Wim Taymans  <wim.taymans@gmail.com>

        * gst-libs/gst/rtp/gstbasertpaudiopayload.c:
        (gst_base_rtp_payload_audio_handle_event):
        Return FALSE from the event handler to let the parent class handle the
        event.

        * gst-libs/gst/rtp/gstbasertpdepayload.c:
        (gst_base_rtp_depayload_chain), (gst_base_rtp_depayload_push_full):
        Mark outgoing buffers as DISCONT if the incomming buffer was DISCONT.

        * gst-libs/gst/rtp/gstbasertppayload.c:
        Bump the MTU to 1400.