GNOME Bugzilla – Bug 467972
Highlight artifacts when rubber-banding Crop Tool rectangle at e.g. 67% zoom.
Last modified: 2007-08-24 16:58:53 UTC
Steps to reproduce: 1) Create a 420x300 image. 2) Choose the Crop Tool and create a pending crop rectangle at (100, 100), 100x100 in size. 3) Zoom to 67% 4) Adjust the crop rectangle Results: There are drawing artifacts; the area invalidated due to highlightning being used does not cause the needed areas to redraw. Expected results: There should be no drawing artifacts due to highlightning being used.
I'll try to solve this before 2.4.
The important step is the zoom level, isn't it?
Yes, I was merely given an example on how to reproduce it, not what is required to reproduce it. The bug is easily fixed, one just invalidate a larger area than what is currently done, for example by adding + 10, width and height at some place in the invalidate/redraw chain, but it would be nice to fix it the Right Way.
Fixed in SVN: 2007-08-24 Michael Natterer <mitch@gimp.org> * app/display/gimpdisplayshell-draw.c (gimp_display_shell_draw_area): don't use SCALEX()/SCALEY() on x/y *and* width/height of the highlight rectangle because that adds up the error introduced by the ceil() contained in these macros. Instead, scale manually and use ceil() on x/y and floor() on width/height. Fixes off-by-one rendering artifacts (bug #467972).