After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 467529 - Check Printing: Align_n not working in custom check definitions
Check Printing: Align_n not working in custom check definitions
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Check Printing
2.2.x
Other All
: Normal minor
: ---
Assigned To: Andreas Köhler
Depends on:
Blocks: backport
 
 
Reported: 2007-08-17 02:10 UTC by David Reiser
Modified: 2018-06-29 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
re-establishes alignment capability and improves text clipping (711 bytes, patch)
2008-04-26 02:08 UTC, David Reiser
committed Details | Review

Description David Reiser 2007-08-17 02:10:50 UTC
Please describe the problem:
Cannot get fields to center or right-align in check fields

Steps to reproduce:
1. enter either 'Align_7 = "right"' or 'Align_7 = right' in the seventh Check Item description in a .chk file
2. Save the check definition
3. print a check using the modified check definition


Actual results:
field 7 is left aligned

Expected results:
field 7 should be right aligned

Does this happen every time?
yes

Other information:
Comment 1 Derek Atkins 2008-04-17 14:16:35 UTC
Strangely some of the code in that block (the debugging) was expecting the Aligh_n built key, but it wasn't building one.   Fixed in trunk in r17089.
Awaiting backport to 2.2.
Comment 2 David Reiser 2008-04-25 04:11:47 UTC
I've just built 17124 trunk, and I can't get anything but left alignment for text. I'm using gtk+ 2.12.8.
Comment 3 Derek Atkins 2008-04-25 12:48:38 UTC
David,

Are you sure that you provided a width for the box in the size configuration?  the Align_n parameter only works if you provide a width.   Most of the existing configurations do NOT provide widths.
Comment 4 David Reiser 2008-04-25 13:30:49 UTC
Type_1 = PAYEE
Coords_1 = 231.0;64.0;270.0;12.0
Align_1 = right

Comment 5 Derek Atkins 2008-04-25 13:48:32 UTC
huh.  you're right, it's not working.  I have no idea why.  It's certainly not a simple "not reading the format" problem like I assumed.  Too bad David Hampton isn't around anymore.  :(   To me the code doesn't look wrong, so I'm not sure what to fix because to me nothing is obviously wrong.
Comment 6 David Reiser 2008-04-26 02:08:28 UTC
Created attachment 109940 [details] [review]
re-establishes alignment capability and improves text clipping
Comment 7 David Reiser 2008-04-26 02:12:41 UTC
aha. It was my fix for clipping in r16475 that disabled alignment. The new attached patch reverts r16475 and adds a pango_layout_set_ellipsize() that gives good text clipping performance.


Comment 8 Andreas Köhler 2008-04-26 16:01:20 UTC
(In reply to comment #1)
> Strangely some of the code in that block (the debugging) was expecting the
> Aligh_n built key, but it wasn't building one.   Fixed in trunk in r17089.
> Awaiting backport to 2.2.

Applied to branches/2.2 as r17113 for GnuCash 2.2.5.

(In reply to comment #6)
> Created an attachment (id=109940) [edit]
> re-establishes alignment capability and improves text clipping

Applied to trunk as r17127.  Waiting for backport.
Comment 9 Andreas Köhler 2008-04-26 17:21:14 UTC
r17127 applied to branches/2.2 as r17139 for GnuCash 2.2.5.
Thanks a lot!
Comment 10 John Ralls 2018-06-29 21:46:16 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=467529. Please update any external references or bookmarks.