After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466853 - Gtk::Box_Helpers::BoxList::insert() has wrong return value.
Gtk::Box_Helpers::BoxList::insert() has wrong return value.
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: build
2.10.x
Other All
: Normal minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2007-08-15 03:38 UTC by Bobby DaSilva
Modified: 2009-05-05 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the return value of insert() (1.40 KB, patch)
2009-04-25 09:56 UTC, Johannes Schmid 		committed Details | Review
Test-case for the bug (806 bytes, text/plain)
2009-04-25 09:58 UTC, Johannes Schmid 		  Details

Description Bobby DaSilva 2007-08-15 03:38:53 UTC 
It returns iterator to the end, instead of a iterator to the element just inserted.
Gtk::Box_Helpers::BoxList is supposed to act like a std container, right?
Comment 1 Murray Cumming 2008-04-02 11:00:38 UTC 
I guess so. Could you provide a patch and a test case?
Comment 2 Murray Cumming 2008-05-16 16:22:44 UTC 
Hi, could you do that, please?
Comment 3 Johannes Schmid 2009-04-25 09:56:52 UTC 
Created attachment 133289 [details] [review]
Fix the return value of insert()

This (rather trivial) patch fixes the return type.
Comment 4 Johannes Schmid 2009-04-25 09:58:30 UTC 
Created attachment 133290 [details]
Test-case for the bug

This is a test-case for the bug. 
(g++ -o box-test box_test.cc `pkg-config --libs --cflags gtkmm-2.4`)

Without the patch this results in a segmentation fault, with the patch it correctly insert the widget and returns it.
Comment 5 Murray Cumming 2009-05-01 11:50:18 UTC 
Yeah, please commit, and add that test case please.