GNOME Bugzilla – Bug 466749
keyboard proerties delete layout button is active inappropriately
Last modified: 2007-08-14 20:49:21 UTC
1. Launch keyboard Behavior (launch--> preference--> desktop preference--> keyboard--> behavior 2. Switch to Layout tab. 3. Add some available layouts (unable to add more than four layouts)and remove all the layouts available. Observation and bug: The following error comesup, Error activating XKB configuration. Probably internal libxklavier or gnome-settings-daemon problem. X server version data: The X.Org Foundation, Inc 60802000 If you report this situation as a bug, please include: - The result of xprop -root | grep XKB - The result of gconftool-2 -R /desktop/gnome/peripherals/keyboard/xkb Output of the commands: xprop -root | grep XKB _XKB_RULES_NAMES_BACKUP(STRING) = "xfree86", "pc104", "us", "", "" _XKB_RULES_NAMES(STRING) = "xfree86", "pc104", "us", "", "" gconftool-2 -R /desktop/gnome/peripherals/keyboard/xkb layouts = [] model = pc104 overrideSettings = false options = [] --- The Remove button is enabled if user selects a layout in "Selected Layout" tab. But it is actually not possible to delete all layouts and have no layout selected at a time. In addition to above condition, the Remove button should only be enabled if the number of layouts in "Selected Layout" tab is greater than 1.
Created attachment 93681 [details] [review] patch fixing the problem.
Actually, IIRC it was supposed to return the default list of layouts (from sysconfig) once you delete the last one. But it is really obscure and unclear feature - your patch handles it nicer. Thanks a bunch, committed.