After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466680 - Top-level elements missing accessibility in Ekiga
Top-level elements missing accessibility in Ekiga
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Patrick Wade
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-14 17:06 UTC by Patrick Wade
Modified: 2008-08-14 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Provide the missing accessible keystrokes for Ekiga (4.82 KB, patch)
2007-08-14 17:08 UTC, Patrick Wade
accepted-commit_now Details | Review
(trunk) Provide the missing accessible keystrokes for Ekiga (6.17 KB, patch)
2007-09-13 15:56 UTC, Patrick Wade
reviewed Details | Review
gmmenuaddon modification for new shortcuts (1.31 KB, patch)
2008-05-27 21:26 UTC, Fabrice Alphonso
none Details | Review
main.cpp modification for new shortcuts (5.59 KB, patch)
2008-05-27 21:27 UTC, Fabrice Alphonso
none Details | Review

Description Patrick Wade 2007-08-14 17:06:48 UTC
Many top-level menu elements of Ekiga are missing keystrokes for accessibility. Most are in place, but not all.
Comment 1 Patrick Wade 2007-08-14 17:08:30 UTC
Created attachment 93657 [details] [review]
Provide the missing accessible keystrokes for Ekiga
Comment 2 Snark 2007-08-14 18:06:14 UTC
Looks neat. You can commit it to trunk.

I guess Damien will tell you to commit to the stable branch too -- but I prefer him to confirm.
Comment 3 Patrick Wade 2007-08-14 18:10:27 UTC
Thanks! My SVN account has problems, so if you could commit instead, I would appreciate it.
Comment 4 Snark 2007-08-15 07:13:57 UTC
Hmmm... it doesn't apply to trunk. Could you check ?

(I applied to gnome-2-14 branch -- hopefully Damien won't strangle me too much)
Comment 5 Damien Sandras 2007-08-15 08:52:16 UTC
Perhaps the strings change needs to be announced.

See http://live.gnome.org/Schedule

I will do it.
Comment 6 Damien Sandras 2007-08-15 09:41:55 UTC
I have created a new gnome-2-20 branch for Ekiga.
Comment 7 Snark 2007-08-15 09:46:18 UTC
I unapplied from the gnome-2-14 branch. I'll apply to gnome-2-20 now.
Comment 8 Damien Sandras 2007-08-15 09:54:51 UTC
I already did :)
Comment 9 Patrick Wade 2007-09-13 15:56:22 UTC
Created attachment 95528 [details] [review]
(trunk) Provide the missing accessible keystrokes for Ekiga

Similar patch for trunk code.
Comment 10 Snark 2007-10-26 18:42:56 UTC
I reviewed your last patch and it looks correct -- but I'm not sure it still applies, since the code moved a lot recently.

Could you check?
Comment 11 Snark 2007-11-24 16:10:25 UTC
Well the situation is the following :
- either the code didn't move that much and the patch will apply more or less cleanly, which a beginner should be able to help with ;
- or the code changed too much and the patch is unfortunately lost. :-(

Marking this bug gnome-love, we'll see what it gives in another two weeks :-/
Comment 12 Fabrice Alphonso 2008-05-27 21:25:17 UTC
I worked on this issue. here are the diff of my changes on two files :
lib/src/gmmmenuaddons.c
src/gui/main.cpp

Menu "Chat":
Call CTRL+O
Hang up Escape
Add a new contact CTRL+O
Hold call H
Transfer call T
Suspend audio M
Suspend video P

Menu "Edit":
no more shortcut to access Preferences

Menu "View":
Show call panel CTRL+J
Local video CTRL+1
Remote video CTRL+2
Picture-In-Picture CTRL+3
P-I-P in separate window CTRL+4
Normal size CTRL+0
Fullscreen F11

Menu "Tools":
Find contacts CTRL+F

I tried at maximum to respect the way shortcuts are adviced ini the HIG for Gnome apps.




Comment 13 Fabrice Alphonso 2008-05-27 21:26:38 UTC
Created attachment 111631 [details] [review]
gmmenuaddon modification for new shortcuts
Comment 14 Fabrice Alphonso 2008-05-27 21:27:46 UTC
Created attachment 111632 [details] [review]
main.cpp modification for new shortcuts
Comment 15 Damien Sandras 2008-08-14 12:17:02 UTC
Finally fixed. Sorry for the HUGE delay, I am really ashamed but I had forgotten about this even though we talked about it during GUADEC. Sigh, I must be getting old :(