GNOME Bugzilla – Bug 465639
Events not exposed over dbus
Last modified: 2008-02-26 20:52:58 UTC
Applications that work with Tomboy over dbus don't know when a note has changed. Please implement event handlers so we can track Add, Modify and Delete operations.
Created attachment 93479 [details] [review] Implement added, saved, renamed and deleted events to RemoteControl.cs Here is my first attempt at this, might need cleaning up. Tested it against Conduit and it works :D I'll write a minimal python script to demonstrate it works later if desired...
John, this looks sweet (who knew it was so easy?). I'd like to see some demo client code, and test it a bunch to see what happens when the dbus client is dead, etc. I'm also not sure if we should expose the NoteRenamed event. I know that sounds convenient, but the way our code currently works that event may be fired several times while editing the the note title...and it might not make sense for a dbus client to respond each time. Just food for thought. :-) Thanks for the awesomeness!
Created attachment 93492 [details] Fun test for attached patch :) Apply my patch, compile, run tomboy. Start this test. Create, save and delete notes... You should see popups - its bottom right for me..
Created attachment 93496 [details] [review] Dbus events - but no renamed event this time.. This removes the Renamed event from dbus and I think i had a typo in the Delete handler.
Created attachment 94306 [details] Test with 4 (commented out) ways to break At Sandy's request, I have added 4 crashers to the test. Enjoy.
Committed in r1443, along with test. I just modified the delete event to pass the title as well as the note URI. The save event gets propagated quite frequently. At some point we should address that. Thanks for the work, John!