Bug 465058 – Segfault when saving account settings

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 465058 - Segfault when saving account settings


Summary:	Segfault when saving account settings


Status:	RESOLVED OBSOLETE

Product:	evolution-data-server
Classification:	Platform
Component:	Mailer
Version:	1.12.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-08-09 14:53 UTC by Matthew Barnes
Modified:	2011-02-19 00:05 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed patch (779 bytes, patch) 2007-08-09 16:36 UTC, Matthew Barnes	needs-work	Details \| Review

Description Matthew Barnes 2007-08-09 14:53:59 UTC

Forwarding this from a downstream bug report:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251391


Description of problem:
I'm getting the following traceback when clicking "Ok" after viewing my account
settings.

+ Trace 153977

#0 strcmp
from /lib/libc.so.6
#1 folder_info_cmp
at camel-store.c line 886
#2 msort_with_tmp
at msort.c line 56
#3 msort_with_tmp
at msort.c line 48
#4 msort_with_tmp
at msort.c line 48
#5 msort_with_tmp
at msort.c line 47
#6 msort_with_tmp
at msort.c line 48
#7 msort_with_tmp
at msort.c line 47
#8 msort_with_tmp
at msort.c line 48
#9 msort_with_tmp
at msort.c line 47
#10 msort_with_tmp
at msort.c line 47
#11 msort_with_tmp
at msort.c line 48
#12 msort_with_tmp
at msort.c line 48
#13 msort_with_tmp
at msort.c line 48
#14 *__GI_qsort
at msort.c line 154
#15 camel_folder_info_build
at camel-store.c line 923
#16 get_folder_info_offline
at camel-imap-store.c line 2862
#17 get_folder_info_online
at camel-imap-store.c line 2768
#18 disco_get_folder_info
at camel-disco-store.c line 256
#19 camel_store_get_folder_info
at camel-store.c line 790
#20 emft_get_folder_info__exec
at em-folder-tree.c line 1715
#21 mail_msg_proxy
at mail-mt.c line 500
#22 g_thread_pool_thread_proxy
at gthreadpool.c line 265
#23 g_thread_create_proxy
at gthread.c line 634
#24 start_thread
at pthread_create.c line 296
#25 clone
from /lib/libc.so.6


Version-Release number of selected component (if applicable):
evolution-2.11.6.1-1.fc8

Comment 1 Matthew Barnes 2007-08-09 14:56:57 UTC

Here's the offending function:

   static int
   folder_info_cmp (const void *ap, const void *bp)
   {
           const CamelFolderInfo *a = ((CamelFolderInfo **)ap)[0];
           const CamelFolderInfo *b = ((CamelFolderInfo **)bp)[0];

           return strcmp (a->full_name, b->full_name);
   }

Looks like another case of not checking for NULL before calling strcmp().

Comment 2 Matthew Barnes 2007-08-09 16:36:47 UTC

Created attachment 93377 [details] [review]
Proposed patch

This patch should fix the immediate problem.

I'm not sure whether it's valid for folder full names to be NULL, so this could just be fixing a symptom of a deeper problem.

Comment 3 Srinivasa Ragavan 2007-08-10 08:06:07 UTC

Sankar/Varadhan?

Comment 4 Veerapuram Varadhan 2007-08-23 12:48:52 UTC

(In reply to comment #2)
> Created an attachment (id=93377) [edit]
> Proposed patch
> 
> This patch should fix the immediate problem.
> 
> I'm not sure whether it's valid for folder full names to be NULL, so this could
> just be fixing a symptom of a deeper problem.
> 
folder full names shouldn't be NULL.  I understand that the patch would fix the crash, however, we need to find out why the folder full names were NULL. Marking the patch as "needs-work".

Comment 5 Matthew Barnes 2008-03-11 01:01:04 UTC

Bumping version to a stable release.

Comment 6 Akhil Laddha 2009-09-17 07:47:42 UTC

Does the patch still hold the value ?

Comment 7 Akhil Laddha 2011-02-10 11:12:56 UTC

Matthew, ping, would you please check if the patch still holds good for master (2.91.6) ?

Comment 8 Matthew Barnes 2011-02-19 00:05:17 UTC

Patch still applies, but I agree with comment #4.  Searching the currently open bugs for comments containing "folder_info_cmp" (and this includes stack traces), this bug is the only hit.  So whatever caused a NULL CamelFolderInfo to be passed to this function seems to have been fixed already.

This bug is over three years old now.  Let's just close it as OBSOLETE.