After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464756 - [gutsy] gdmsetup ignores "Use24Clock" setting
[gutsy] gdmsetup ignores "Use24Clock" setting
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-08 16:36 UTC by Sebastien Bacher
Modified: 2007-08-09 19:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
use CLOCK_YES correctly (699 bytes, patch)
2007-08-08 16:38 UTC, Sebastien Bacher 		none Details | Review

Description Sebastien Bacher 2007-08-08 16:36:03 UTC 
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/129528

"Binary package hint: gdm

Architecture: i386
Version: 2.19.5-0ubuntu1

gdmsetup seems to set "Use 24 Hour Clock" to "auto" even though the value was previously set as "yes".
/etc/gdm.conf-custom contains Use24Clock=yes, but the GUI doesn't reflect that."
Comment 1 Sebastien Bacher 2007-08-08 16:38:27 UTC 
Created attachment 93293 [details] [review]
use CLOCK_YES correctly

The patch fixes the issue by using the correct enum value
Comment 2 Lukasz Zalewski 2007-08-08 16:54:12 UTC 
This also has been noted as one of the issues amongst many in the bug #449735
Comment 3 Brian Cameron 2007-08-08 21:14:28 UTC 
Yes, and the patch for fixing bug #449735 is in bug #404891.  

It might be good to break up that monster patch into 2 parts.  One patch that is things we could apply today to 2.19 to fix real problems users are having, and a second patch that implements the "improve the race condition and how the greeters are updated with new configuration options".

Lukasz, would you be up for providing a new patch that fixes the more serious and obvious problems in the big patch, so we can get some issues fixed in the 2.20 timeframe.  Remember that since we are past freeze date we can only fix issues that don't affect strings and are bugs (rather than enhancing the GUI with new functionality).

That said, if there are any serious bugs you think should be fixed in 2.20 even though it might break API/string/etc. freeze, then we can seek approval.

At any rate, this patch looks good and I'm committing this to SVN head.
Comment 4 Lukasz Zalewski 2007-08-09 19:43:35 UTC 
Hmmm Im not sure if this will be easy as all the fixes are built on top of changed gdmsetup code (i.e. without the timeout function and local variable cache). I think the only stuff that we can easily extract without too much trouble are minor interface glitches etc.