After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464678 - Add connection-speed property to mmssrc element
Add connection-speed property to mmssrc element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-08 12:32 UTC by Josep Torra Valles
Modified: 2007-08-08 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to implement it (3.68 KB, patch)
2007-08-08 12:33 UTC, Josep Torra Valles
none Details | Review
Patch to implement it (4.50 KB, patch)
2007-08-08 13:39 UTC, Josep Torra Valles
committed Details | Review

Description Josep Torra Valles 2007-08-08 12:32:18 UTC
The 4th parameter of libmms/mms_connect() is the bandwidth available, libmms uses this argument in the stream activation strategy.

Currently the bandwidth available is hardcoded to 128kbps, this cause some problems.

I propose add connection-speed property to that element so it can be properly selected.

The value 0 for bandwidth will take the meaning unknown, and max bandwitdh will be passed to libmms, this will ensure that best audio and video streams are activated  in the server side and the other ones are deactivated.

Current strategy for stream selection in libmms is:

bandwidth_avil = x
1) select the audio stream with the max bitrate
2) bandwidth_avil -= selected_audio_stream_bitrate
3) try to select the video stream with a higher bitrate constrained to the remaining bandwidth.
4) if no video stream is selected, select the video stream with the lowest bitrate.
Comment 1 Josep Torra Valles 2007-08-08 12:33:06 UTC
Created attachment 93269 [details] [review]
Patch to implement it
Comment 2 Josep Torra Valles 2007-08-08 13:39:13 UTC
Created attachment 93275 [details] [review]
Patch to implement it

Added doc to the previous patch
Comment 3 Wim Taymans 2007-08-08 15:18:09 UTC
        Patch by: Josep Torre Valles <josep@fluendo.com>

        * docs/plugins/gst-plugins-bad-plugins.args:
        * ext/libmms/gstmms.c: (gst_mms_class_init), (gst_mms_init),
        (gst_mms_start), (gst_mms_set_property), (gst_mms_get_property):
        * ext/libmms/gstmms.h:
        Add connection speed property to libmms. Fixes #464678.