After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464173 - Critical warning on gtk_tree_model_filter_refilter and an invisible level
Critical warning on gtk_tree_model_filter_refilter and an invisible level
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
: 544794 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-07 00:14 UTC by Andreas Köhler
Modified: 2009-09-05 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test case (1.94 KB, text/plain)
2007-08-07 00:15 UTC, Andreas Köhler 		  Details
Do not emit child_toggled with !level->parent_elt->visible (473 bytes, patch)
2007-11-25 13:24 UTC, Andreas Köhler 		none Details | Review

Description Andreas Köhler 2007-08-07 00:14:42 UTC 
Please see the following test case.

Gtk-CRITICAL **: gtk_tree_model_row_has_child_toggled: assertion `path != NULL' failed

will be printed to the terminal.
Comment 1 Andreas Köhler 2007-08-07 00:15:21 UTC 
Created attachment 93178 [details]
test case
Comment 2 Peter Clifton 2007-08-12 13:03:14 UTC 
I see this too, when filtering a model down to no rows displayed.
Comment 3 Andreas Köhler 2007-11-25 13:24:02 UTC 
Created attachment 99616 [details] [review]
Do not emit child_toggled with !level->parent_elt->visible

Please consider this patch.
I hope that it does not break more than it helps.
Comment 4 Peter Clifton 2009-01-03 23:39:07 UTC 
Can we mark this bug as confirmed.. it is still present right up to the latest GTK release - and there is a patch here...

Has anyone got the time to review it?
Comment 5 Stef Walter 2009-02-07 04:08:59 UTC 
This happens in seahorse when the user types the 'filter' box near the top. When trying to fix this problem, I came to the same conclusion as the patch.
Comment 6 Stef Walter 2009-02-07 04:12:17 UTC 
*** Bug 544794 has been marked as a duplicate of this bug. ***
Comment 7 Stef Walter 2009-02-07 04:14:32 UTC 
Bug 544794 has an alternate patch, but the patch here looks like it solves the problem in a better manner.
Comment 8 Kristian Rietveld 2009-09-01 09:26:14 UTC 
I am working on an extensive GtkTreeModelFilter unit test suite now and I have added a test for this bug using the test case in comment 1.  This test suite will (finally) help us see whether a patch does not break more than it helps ;)  I will be finishing the first work on the test case soon and then move on with fixing the current bugs reported in Bugzilla.
Comment 9 Kristian Rietveld 2009-09-05 15:27:57 UTC 
Fixed on master.  The correct fix is similar to what Andreas posted in comment 3, but it needs to check all parents of a certain level, not just the direct parent.