After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 463632 - generic player playlist creation, editing, deletion
generic player playlist creation, editing, deletion
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 369415 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-05 11:38 UTC by Jonathan Matthew
Modified: 2007-12-29 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (92.09 KB, patch)
2007-08-05 11:59 UTC, Jonathan Matthew
committed Details | Review

Description Jonathan Matthew 2007-08-05 11:38:39 UTC
I recently found a firmware update for my player that added playlist functionality.  So here we are.
Comment 1 Jonathan Matthew 2007-08-05 11:59:06 UTC
Created attachment 93105 [details] [review]
patch

Notable things:
- adds entry types to use for ignored and error types to rhythmdb_add_uri_with_type
- makes mark_dirty a virtual method on RBPlaylistSource
- adds a 'has_playlists' field in RhythmDBEntryType, used to determine whether the 'add to playlist' action should be enabled
- links rhythmdb into the core shared library rather than the rhythmbox binary
- adds RhythmDBImportJob, a way to import a set of directories and get status information (total files, files imported so far) and completion signals
- uses that to load playlists on the player only once all files have been imported (otherwise we don't preserve the playlist order)
- adds an import errors source under the generic player source (there's a bug about that somewhere)
- adds support for iriver .pla playlists (if you have a new enough totem)
Comment 2 James "Doc" Livingston 2007-09-16 10:39:39 UTC
Looks pretty good to me, although I haven't actually tested the support for generic-player playlists.

The "import job" stuff sounds nice, and could probably be extended to a "job" interface in the future (for cd ripping, podcast downloads et al).
Comment 3 Jonathan Matthew 2007-10-14 05:04:38 UTC
committed to svn.
Comment 4 Jonathan Matthew 2007-12-29 11:57:21 UTC
*** Bug 369415 has been marked as a duplicate of this bug. ***