After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462787 - broken image object insertion
broken image object insertion
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Sheet Objects
1.7.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2007-08-02 13:39 UTC by Valek Filippov
Modified: 2007-08-25 02:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
set w and h to 50 if it's less than 5 (388 bytes, patch)
2007-08-02 13:40 UTC, Valek Filippov
none Details | Review

Description Valek Filippov 2007-08-02 13:39:27 UTC
How to reproduce.
- Copy any non-image binary file to 'test.bmp' to imitate broken image file
- Run gnumeric
- "Insert->Image"
- Choose your 'test.bmp' file
- Click anywhere on sheet to insert it
- Click somewhere also on the sheet to deselect an 'image'

 Now you have a small object that is quite hard to remove (much easier to remove cell or row/column where it was placed).

Patch for quick fix is attached.

It would be better to improve gnm_soi_new_view or soi_get_pixbuf,
if pixbuf == NULL it have to show some warning dialog and cancel image insertion instead of copying 'unknown_image' placeholder.
Comment 1 Valek Filippov 2007-08-02 13:40:55 UTC
Created attachment 92918 [details] [review]
set w and h to 50 if it's less than 5

See a suggestion in the bug description.
Comment 2 Jody Goldberg 2007-08-25 02:30:13 UTC
I don't like the idea of applying these clamps arbitrarily.
People could insert lines  200x1.  Added a heuristic to only apply them when area is small to catch failed pixbufs.