After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462752 - make gst_element_class_set_details_simple args const
make gst_element_class_set_details_simple args const
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal trivial
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-02 11:13 UTC by Tim-Philipp Müller
Modified: 2007-08-02 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
make arguments to gst_element_class_set_details_simple() constant (2.21 KB, patch)
2007-08-02 11:13 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2007-08-02 11:13:17 UTC
If you're doing another pre-release anyway, please let's fix up the API for gst_element_class_set_details_simple() and make the arguments passed to it const. This was API newly added for 0.10.14.
Comment 1 Tim-Philipp Müller 2007-08-02 11:13:58 UTC
Created attachment 92911 [details] [review]
make arguments to gst_element_class_set_details_simple() constant
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-08-02 11:32:13 UTC
I've tried that once too. The resulting code was no different if I recall right, but seems to be more clear API wise. SO +1 from my side.
Comment 3 Jan Schmidt 2007-08-02 11:42:44 UTC
go for it then. Best to fix API before it's released :)
Comment 4 Tim-Philipp Müller 2007-08-02 12:07:50 UTC
2007-08-02  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/gstelement.c: (gst_element_class_set_details_simple):
        * gst/gstelement.h:
          Make strings passed to gst_element_class_set_details_simple()
          constant, as they should be (#462752).