After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462551 - Include Tango style application icon
Include Tango style application icon
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-Sound-Recorder
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
: 541084 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-01 17:52 UTC by Stephen Brandt
Modified: 2008-08-12 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Tango styled GNOME Sound Recorder app icon (25.43 KB, application/x-gzip)
2007-08-01 17:54 UTC, Stephen Brandt
  Details
Optimized version of Stephen Brandt's gnome-grecord icon (25.43 KB, application/x-compressed-tar)
2007-08-16 15:06 UTC, Pascal Klein
  Details
Some minor changes (9.96 KB, application/x-compressed-tar)
2007-08-16 17:15 UTC, Pascal Klein
  Details
[1/1] 2008-04-05 Marc-Andre Lureau <marcandre.lureau@gmail.com> (78.13 KB, patch)
2008-04-05 11:23 UTC, Marc-Andre Lureau
none Details | Review
Tango styled GNOME Sound Recorder app icon (correctly optimized by original author) (39.36 KB, application/x-gzip)
2008-04-05 17:39 UTC, Stephen Brandt
  Details

Description Stephen Brandt 2007-08-01 17:52:55 UTC
The current icon for GNOME Sound Recorder is using wrong style (old GNOME instead new Tango).

The new icon should follow the Tango Style Guidelines[1], and installed under $(datadir)/icons/hicolor/{size}/apps/ directory [2].

[1] http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines
[2] http://live.gnome.org/GnomeGoals/AppIcon
Comment 1 Stephen Brandt 2007-08-01 17:54:50 UTC
Created attachment 92868 [details]
Tango styled GNOME Sound Recorder app icon
Comment 2 Pascal Klein 2007-08-16 15:06:33 UTC
Created attachment 93784 [details]
Optimized version of Stephen Brandt's gnome-grecord icon

Nice work Stephen. :)

I took your icon and edited the SVG slightly and vacuumed over a 100 unused defs. PNG export is also included. It's been crushed with optipng.
Comment 3 Stephen Brandt 2007-08-16 15:53:25 UTC
> I took your icon and edited the SVG slightly and vacuumed over a 100 unused
> defs. PNG export is also included. It's been crushed with optipng.

As far as I can see the attachment is exactly the same data, but with missing application/x-gzip type definition...?

How do you remove 'unused defs', is there an option to do so in Inkscape? I saved it as 'Plain SVG' already.
Hope you didn't alter the SVG visually without consulting by the way.

Will have a look at optipng.
Comment 4 Pascal Klein 2007-08-16 16:18:36 UTC
> As far as I can see the attachment is exactly the same data, but with missing
> application/x-gzip type definition...?

I removed the red glare behind the record icon and gave it a drop shadow. Otherwise the changes were more in the nature of aligning objects to the grid and changing the odd shade to colours from the Tango colour palette.

> How do you remove 'unused defs', is there an option to do so in Inkscape? I
> saved it as 'Plain SVG' already.

File -> Vacuum defs.

> Hope you didn't alter the SVG visually without consulting by the way.

Not really.
Comment 5 Stephen Brandt 2007-08-16 17:04:50 UTC
Again, how in the world can I see the contents of this 'patch' type??? I'm not an uber l33t h4x0r, so please tell me.

Without seeing though, I'm not happy with what you are doing. First, when you change the looks (you apparently did, really) of the icon you should submit it as proposal, not as patch.

More detailed, I aligned everything perfectly a 1px grid. The 'odd shade' color is 100% black. The red glare is there because the record icon gives light. Everything I designed has been well thought over and I don't like my efforts being screwed.
Comment 6 Pascal Klein 2007-08-16 17:15:14 UTC
Created attachment 93799 [details]
Some minor changes

I have no idea why bugzilla mauled that attachment. Sorry for the confusion.
Comment 7 Stephen Brandt 2007-08-16 19:09:04 UTC
To sum up, now that I've finally seen the actual icon change proposal and spoken to Pascal over IRC:

Non-essential improvements that could be done to the original icon:
- Optimize PNG file size
- Remove unused defs from SVG file
- Improve alignment to the grid
- Check transparent gradient colors to be on palette

NOT to be done:
- Change red record glare to shadow
Comment 8 Jones Lee 2008-04-03 22:59:01 UTC
I see no action on committing the patches. What's wrong with the current icon?
Comment 9 Stephen Brandt 2008-04-04 16:16:08 UTC
Jones Lee:

If you refer to 'current' as in the upstream one, my answer is crappy old style.

If you refer to the original icon I submitted in this bug report, my answer is that there's nothing wrong with it (although can be optimized to mainly reduce file size).

I think there's a lack of time and/or priority by responsible maintainers for committing icons (or artwork in general). As result I haven't made optimizing the icon a top priority myself, and have lately been focusing on creating a complete icon theme (following Tango-guidelines) of my own. That way I don't have to waste time on politics like persuading maintainers to please, PLEASE commit the icon. 

Good artists in FOSS community are scarce, my oh my I wonder why...
Comment 10 Vincent Untz 2008-04-04 17:01:34 UTC
You generally don't have to convince maintainers. gnome-media is a special case, since it was under-maintained. It should hopefully be better now.
Comment 11 Marc-Andre Lureau 2008-04-05 11:23:07 UTC
Created attachment 108663 [details] [review]
[1/1] 2008-04-05  Marc-Andre Lureau  <marcandre.lureau@gmail.com>


	* icons/{16x16,22x22,24x24,32x32,48x48}: add Tango style icons
	(see #462551)
---
 configure.in                             |    7 +
 grecord/ChangeLog                        |    5 +
 grecord/Makefile.am                      |   18 +-
 grecord/gnome-grecord.png                |  Bin 4655 -> 0 bytes
 grecord/icons/16x16/Makefile.am          |    4 +
 grecord/icons/16x16/gnome-grecord.png    |  Bin 0 -> 825 bytes
 grecord/icons/22x22/Makefile.am          |    4 +
 grecord/icons/22x22/gnome-grecord.png    |  Bin 0 -> 1261 bytes
 grecord/icons/24x24/Makefile.am          |    4 +
 grecord/icons/24x24/gnome-grecord.png    |  Bin 0 -> 1284 bytes
 grecord/icons/32x32/Makefile.am          |    4 +
 grecord/icons/32x32/gnome-grecord.png    |  Bin 0 -> 2348 bytes
 grecord/icons/48x48/Makefile.am          |    4 +
 grecord/icons/48x48/gnome-grecord.png    |  Bin 0 -> 3817 bytes
 grecord/icons/AUTHORS                    |    1 +
 grecord/icons/Makefile.am                |   14 +
 grecord/icons/scalable/Makefile.am       |    4 +
 grecord/icons/scalable/gnome-grecord.svg | 1355 ++++++++++++++++++++++++++++++
 18 files changed, 1408 insertions(+), 16 deletions(-)
Comment 12 Marc-Andre Lureau 2008-04-05 11:25:25 UTC
Stephen, thanks a lot for your contribution! We owe a lot to artist contributors like you. Sorry for not replying earlier, I either didn't see this bug or thought that it still requires some minor work. 

I did not comitted the previous patch, because I can't get it work (my cache does not want to update?)

I took the second tarball icons, with the update from the last one (hope that's correct). I had to rename the files. And I wished gnome-hello had such a icon template with pix&scalable that I could copy'n paste. 

Vuntz, do you think this patch is ok?
Comment 13 Marc-Andre Lureau 2008-04-05 11:27:05 UTC
oups, I'll mention author name in the changelog.
Comment 14 Vincent Untz 2008-04-05 11:45:08 UTC
Marc-André: you need to keep some gtk-update-icon-cache command somewhere. See http://live.gnome.org/GnomeGoals/AppIcon
Comment 15 Marc-Andre Lureau 2008-04-05 13:13:28 UTC
(In reply to comment #14)
> Marc-André: you need to keep some gtk-update-icon-cache command somewhere. See
> http://live.gnome.org/GnomeGoals/AppIcon
> 

it's there in grecord/icons/Makefile.am, look at the diff. I checked, it's called correctly. No idea why my cache is not refreshed.
Comment 16 Stephen Brandt 2008-04-05 17:39:11 UTC
Created attachment 108679 [details]
Tango styled GNOME Sound Recorder app icon (correctly optimized by original author)

* File optimizations for both PNG and SVG icons
* Added Inkscape SVG source files for all sizes
Comment 17 Stephen Brandt 2008-04-05 17:46:24 UTC
Please use the icons from the package I just submitted. Thanks for your effort to get it upstream.

- Stephen
Comment 18 Marc-Andre Lureau 2008-04-06 09:32:59 UTC
(In reply to comment #17)
> Please use the icons from the package I just submitted. Thanks for your effort
> to get it upstream.
> 
> - Stephen
> 

Hi Stephen,

Should I include the COPYING LGPL 2.1 file?

grecord is LGPL 2, no incompatibility?

(marcandre, who never get it when it comes to licenses)
Comment 19 Stephen Brandt 2008-04-06 10:49:15 UTC
Hi Marc-Andre,

Good question. You shouldn't include the COPYING file, the icon inherits whatever license that is chosen for the project itself.

I just added de COPYING file for people who may download the package separately (from this bug report for example).
Comment 20 Marc-Andre Lureau 2008-04-06 11:12:32 UTC
ok, committed with your updated tarball. Thanks
Comment 21 Michael Monreal 2008-04-08 12:30:03 UTC
Please also make sure the old gnome-grecord icon will be removed from gnome-icon-theme, as it currently takes a higher priority then the hicolor icon you installed (->gnome/48x48/apps/gnome-grecord.png)
Comment 22 Jones Lee 2008-04-08 12:42:22 UTC
Bug filled http://bugzilla.gnome.org/show_bug.cgi?id=526933
Comment 23 Marc-Andre Lureau 2008-08-12 21:50:13 UTC
*** Bug 541084 has been marked as a duplicate of this bug. ***