After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462338 - [plugin] python console
[plugin] python console
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
eog-plugin
Depends on: 460781
Blocks:
 
 
Reported: 2007-08-01 01:56 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2019-02-22 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pythonconsole plugin (40.00 KB, application/x-tar)
2007-08-01 02:01 UTC, Diego Escalante Urrelo (not reading bugmail)
  Details
[PATCH] Python Console plugin (14.29 KB, patch)
2008-08-01 16:21 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review
[PATCH] Build modifications for Python Console plugin (623 bytes, patch)
2008-08-01 16:21 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
patch (3.30 KB, patch)
2009-02-13 04:17 UTC, Francisco Rojas
committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2007-08-01 01:56:27 UTC
Adapted from gedit's epiphany's adaptation.

See attachment.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 02:01:50 UTC
Created attachment 92829 [details]
pythonconsole plugin

Note that this exposes a bug that makes eog keep running after being closed.
Comment 2 Felix Riemann 2007-08-05 08:17:53 UTC
Comment on attachment 92829 [details]
pythonconsole plugin

Setting correct MIME type.
Comment 3 Felix Riemann 2007-08-05 08:19:00 UTC
Comment on attachment 92829 [details]
pythonconsole plugin

Sorry.
Comment 4 Felix Riemann 2007-09-23 22:35:03 UTC
Just tried it and I get this output upon unloading:

Traceback (most recent call last):
  • File "/home/felix/gnome-debug-ng/lib/eog/plugins/pythonconsole/__init__.py", line 71 in deactivate
    ui_manager.remove_ui(ui_id)
NameError: global name 'ui_id' is not defined

Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 16:21:33 UTC
Created attachment 115696 [details] [review]
[PATCH] Python Console plugin


The python console plugin, still rough edges, but updated to svn trunk.
---
 plugins/pythonconsole/Makefile.am                  |   16 +
 plugins/pythonconsole/console.py                   |  304 ++++++++++++++++++++
 .../pythonconsole.eog-plugin.desktop.in            |   10 +
 plugins/pythonconsole/pythonconsole.py             |   79 +++++
 4 files changed, 409 insertions(+), 0 deletions(-)
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 16:21:36 UTC
Created attachment 115697 [details] [review]
[PATCH] Build modifications for Python Console plugin


This enables the Python Console build
---
 configure.ac        |    1 +
 plugins/Makefile.am |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 16:23:31 UTC
Hey, updated to trunk, attached with git sweetness.

It works fine again, the only issue is that the console window pops up like 20x20. Which is not good :).
But, since I don't want to get blocked by freeze... what do you think?
Comment 8 Felix Riemann 2008-08-19 12:01:43 UTC
Looks like we have a "plugins" component now. :-)
Switching to it.
Comment 9 Felix Riemann 2008-08-19 12:09:34 UTC
Well, I guess the biggest problem is that we still haven't found a solution for bug #460781 yet. We can't ship it unless eog behaves normally when using it.

As a minor "optimization" it should be only built/installed if eog is actually being built with python support. See how it is done for the statusbar-date plugin. It's only added to SUBDIRS if dbus support is compiled in. But this is only minor as it won't break the build anyways.
Comment 10 Francisco Rojas 2009-02-13 04:17:49 UTC
Created attachment 128617 [details] [review]
patch

It's been a while that nobody comment this bug. This patch it close to fix the problem. if you deactivate the plugin before quit eog, eog quit. I know isn't fix the problem, but I just want show my code :-P.
Comment 11 Felix Riemann 2009-02-14 11:17:43 UTC
Works pretty well now. I also tried adding a little hack/workaround locally to disable the plugin when the window that was used for activation (aka the first one) is closed. That way you can even leave it active. Makes working with multiple windows harder though.

Let's see if I can push it to eog-plugins.
Comment 12 Felix Riemann 2009-02-15 11:00:27 UTC
Just landed in the eog-plugins tree. Thanks guys: 

2009-02-15  Felix Riemann  <>

	* configure.ac:
	* plugins/pythonconsole/*:
	Add pythonconsole plugin based on the gedit plugin of the same name.
	Fixes bug #462338 (Diego Escalante Urrelo, Francisco Rojas).

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.