GNOME Bugzilla – Bug 462264
suppress key repeat for Return in greeter
Last modified: 2010-06-17 02:41:02 UTC
If the user appears to lean on the Return key, an indefinite series of empty usernames will cause the gdm greeter and slave to beep a lot. This is particularly a problem because this situation can be simulated occasionally when using fast user switching. To reproduce: 1. Log in as user A 2. Switch user to B (results in starting a gdmflexiserver as B) 3. Return to A's session and log out 4. At the prompt, enter B's username and password gdm will, if configured appropriately, automatically and without asking immediately switch VTs to B's session. The greeter continues to run on the original VT, but the VT switch happened while the Return key was still depressed. So the greeter sees a key repeat. I have worked around this problem with the patch against gdm which I will attach shortly. This suppresses all but the first KEY_PRESS event following any KEY_RELEASE event (for GDK_Return).
Created attachment 92816 [details] [review] patch to supress key repeat on Return in greeter
This patch looks good. However, you need to make the similar change to gdmlogin in its gdm_event function. Note that aside from the logic for how to handle Ctrl-U the code is identical between these two functions. It might be nice to move the common code into gui/gdmcommon.c and just call a function to handle the common things (translating mouse button and your new code). If you don't want to bother doing this, I'd accept a patch that just continued to duplicate logic in the two files. I will accept this patch once you fix the problem for gdmlogin also.
*** Bug 402028 has been marked as a duplicate of this bug. ***
Note if you are mucking around with this code anyway, it would be awesome if you also fixed bug #318958. People complain that GDM allows spaces to be entered into the entry field, when it is not a valid character for username or password. It should be easy to make these functions ignore the space key.
Also, note related bug #308171. Does this fix address that problem as well, or does it have a similar fix?
*ping* Is it possible to finish up this so it can go into 2.20?
Can this patch be updated to be workable? I'd like to get this into 2.20. Would be nice to also fix bug #308171.
*** Bug 324972 has been marked as a duplicate of this bug. ***
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.