GNOME Bugzilla – Bug 462164
Should listen to GStreamer bus events
Last modified: 2008-06-02 19:21:21 UTC
This bug has been filled here: https://bugs.launchpad.net/gnome-media/+bug/34947 "Slider in Volume Control does not update after you adjust the slider on volume applet. Steps to reproduce: 1.) open volume control 2.) on the volume applet, move the sound all the way down. see that volume contol slider is now at bottom 3.) now on the volume applet move it to the middle 4.) volume control slider is still at the bottom and still thinks the volume is muted"
Some additional observations: 1. When volume control is opened, moving the applet slider all way down will mute the track. It will reamains muted even though you move it up. (without volume-control, no such issue) 2. Volume control does not seem to handle the update events when the track is muted.
(In reply to comment #1) > Some additional observations: > > 1. When volume control is opened, moving the applet slider all way down will > mute the track. It will reamains muted even though you move it up. (without > volume-control, no such issue) I removed this behaviour in my patch to the mixer applet. Not really related anyway. > 2. Volume control does not seem to handle the update events when the track is > muted. gnome-volume-control needs to listen to the bus and update itself accordingly. That would save all the polling and would get us updates in real-time.
done. patch follows, I'll push it in the coming 2.23.3 release.
Created attachment 111989 [details] [review] [PATCH] 2008-06-02 Marc-André Lureau <marcandre.lureau@gmail.com> * gst-mixer/src/element.c: * gst-mixer/src/track.{c,h}: * gst-mixer/src/volume.{c,h}: Listen to GStreamer bus events for mixers that supports it. (Closes #462164) --- ChangeLog | 9 +++++++++ gst-mixer/src/element.c | 42 +++++++++++++++++++++++++++++++++++++++++- gst-mixer/src/track.c | 30 ++++++++++++++++++++++-------- gst-mixer/src/track.h | 2 ++ gst-mixer/src/volume.c | 32 ++++++++++++++++++++++---------- gst-mixer/src/volume.h | 1 + 6 files changed, 97 insertions(+), 19 deletions(-)
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.