After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461989 - show category icon on categories editor dialog.
show category icon on categories editor dialog.
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
1.12.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-07-31 00:04 UTC by Hiroyuki Ikezoe
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
snapshot (22.66 KB, image/png)
2007-07-31 00:05 UTC, Hiroyuki Ikezoe 		  Details
proposed patch (7.66 KB, patch)
2007-07-31 00:07 UTC, Hiroyuki Ikezoe 		accepted-commit_now Details | Review

Description Hiroyuki Ikezoe 2007-07-31 00:04:52 UTC 
It's better to show category icon on categories editor dialog.
Comment 1 Hiroyuki Ikezoe 2007-07-31 00:05:15 UTC 
Created attachment 92746 [details]
snapshot
Comment 2 Hiroyuki Ikezoe 2007-07-31 00:07:38 UTC 
Created attachment 92747 [details] [review]
proposed patch

The patch fixes memory leaks: Free return value of gtk_filechooser_get_filename().
Comment 3 Hiroyuki Ikezoe 2007-07-31 00:08:36 UTC 
Ooops!

I mean the patch fixes memory leaks *too*
Comment 4 Srinivasa Ragavan 2007-08-02 10:02:35 UTC 
Johnny, can you review/test this right away?

Hiroyuki, the screenshot looks nice :-) After the approval, make sure that you announce to the doc list.
Comment 5 Hiroyuki Ikezoe 2007-08-02 12:14:37 UTC 
Sure. The list is gnome-doc-list, isn't it?
Comment 6 Johnny Jacob 2007-08-03 08:42:30 UTC 
Patch is good to commit . Please add Bug # in changelog (helps in NEWS file generation)

and yep it is gnome-doc-list@gnome.org ..
Comment 7 Hiroyuki Ikezoe 2007-08-03 13:04:03 UTC 
Done.

2007-08-03  Hiroyuki Ikezoe  <poincare@ikezoe.net>

        ** Fix for bug #461989

        * e-categories-dialog.c: Show category icons.
        Plugged memory leaks. The return value of
        gtk_filechooser_get_filename() should be freed.