GNOME Bugzilla – Bug 46127
test module doesn't handle cancelling well
Last modified: 2018-08-17 13:47:39 UTC
This is a follow-up from bug 40865. The test module (code in test-method.c) lets you make certain gnome-vfs operations slow. This lets you see how Nautilus behaves with certain operations being really slow, which is great. One minor issue with the current implementation is that the slowness is done with a single uninterruptable usleep (total_delay) call. So the Nautilus UI for cancelling slow operations doesn't work well with the test module; the Cancel button in the timed-wait dialog stays visibly depressed until the usleep period is over, and then the operation is reversed. To reproduce (one of many ways: (1) Set up the test-method (instructions at top of test-method.c) to make set_file_info really slow (add a delay of 10 seconds). (2) Launch Nautilus as root (3) Type "test:///home" into the location bar (4) Right-click on some folder or file and choose "Show Properties". (5) Click on the Permissions tab (6) Choose a different owner from the Owner option menu. After a few seconds, the Nautilus timed-wait cancel dialog will appear. (7) Click the Cancel button in the little timed-wait cancel dialog. At this point, the dialog should go away and the owner reset to its previous value. Instead, the Cancel button remains visually depressed until the 10-second usleep delay is finished. (At which time the operation is successfully reversed.) ------- Additional Comments From snickell@stanford.edu 2001-07-23 00:32:46 ---- Taking bugs previously assigned to Pavel, assigning them to myself. Will parse them out at my leisure , but many are GnomeVFS bugs we should look at for 2.0 ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:57 -------
MASS CHANGE VFS. Re-assigning bugs that I currently own in VFS to the proper owner (probably Alex).
Created attachment 70743 [details] [review] Proposed patch The attached patch hard-codes an interval of 0.1 seconds for checking a pending cancellation request. It required a few modifications, especially removal of some const optimizations applied before. I hope/guess this doesn't hurt too much.
Updating version, milestone.
gnome-vfs got deprecated in 2008. gnome-vfs is not under active development anymore and had its last code changes in 2011. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-vfs/commits/master gio (in glib) and gvfs are its successors. See https://developer.gnome.org/gio/stable/ch33.html and https://people.gnome.org/~gicmo/gio-migration-guide/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of glib/gio/gvfs. Thanks!