After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461056 - gdm should do console-kit unlock on migrate even for non FLEXI
gdm should do console-kit unlock on migrate even for non FLEXI
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.19.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-27 19:54 UTC by Ian Jackson
Modified: 2007-08-29 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix this bug (828 bytes, patch)
2007-07-27 19:54 UTC, Ian Jackson
none Details | Review

Description Ian Jackson 2007-07-27 19:54:19 UTC
If you're using consolekit, gdm can arrange that when you "migrate" to an existing session, it will automatically unlock for you as well.

The code to implement this in gdm 2.19.4, however, fails to send this notification when the greeter (into which the user has just entered their login details) is not TYPE_FLEXI.  This is incorrect; this should be done for all greeters when migration is appropriate.

Otherwise users will sometimes get a spurious gnome-screensaver lock: this will happen when they use the greeter which appears when the first user to log in (who used the :0 server which is not TYPE_FLEXI) logs out.

I will shortly attach a patch to fix this problem.  The patch de-duplicates some of the migration code, at the expense of duplicating the if (...TYPE_FLEXI) test.  This seemed appropriate as the migration code was expanding.  An alternative would of course be to duplicate the #if...unlock_ck_session...#endif.

I have tested this patch on Ubuntu with gdm-2.19.4-0ubuntu2.
Comment 1 Ian Jackson 2007-07-27 19:54:40 UTC
Created attachment 92572 [details] [review]
patch to fix this bug
Comment 2 Brian Cameron 2007-07-30 17:20:17 UTC
cc:ing William - can you review this?
Comment 3 Brian Cameron 2007-08-09 23:11:03 UTC
Jon?
Comment 4 William Jon McCann 2007-08-29 17:13:40 UTC
Yeah, I guess that makes sense.
Comment 5 Brian Cameron 2007-08-29 19:50:12 UTC
Patch accepted into 2.18 and 2.19 branches.  Thanks, Jon for reviewing.