Bug 460235 – Crash when printing (print_printer_combo_cb)

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 460235 - Crash when printing (print_printer_combo_cb)


Summary:	Crash when printing (print_printer_combo_cb)


Status:	RESOLVED FIXED

Product:	galeon
Classification:	Deprecated
Component:	general
Version:	2.0.3
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	galeon-maint
QA Contact:	galeon-maint

URL:
Whiteboard:

Duplicates:	475398 487330 492613 493292 495471 496009 501713 504180 507571 509064 511604 516295 (view as bug list)
Depends on:
Blocks:

Reported:	2007-07-25 13:37 UTC by Pascal Terjan
Modified:	2008-02-14 06:39 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
The stacktrace (154.27 KB, text/plain) 2007-07-25 13:38 UTC, Pascal Terjan		Details
Fixes the print dialog crash (928 bytes, patch) 2007-09-19 17:16 UTC, Denis Leroy	committed	Details \| Review

Description Pascal Terjan 2007-07-25 13:37:45 UTC

Selected Print in the File menu, the dialog box appeared and then galeon crashed before it got drawn.

Attaching the trace as i can't submit it (comment too large)

Comment 1 Pascal Terjan 2007-07-25 13:38:40 UTC

Created attachment 92397 [details]
The stacktrace

Comment 2 Yanko Kaneti 2007-07-25 14:03:24 UTC

Thanks for the report.

+ Trace 150450

#4 <signal handler called>
#5 print_printer_combo_cb
at print-dialog.c line 678

Comment 3 Pascal Terjan 2007-09-10 09:23:12 UTC

*** Bug 475398 has been marked as a duplicate of this bug. ***

Comment 4 Denis Leroy 2007-09-19 17:16:32 UTC

Created attachment 95857 [details] [review]
Fixes the print dialog crash

There seems to be a behavior change with Gtk 2.20. In this case, the print dialog gets its combo callback called *twice*: once before its show() method is called (which didn't happen with gtk 2.18), and once after. Problem is, when it's called before, the combo value is at -1 and that sets the selected_printer variable, hence the crash.

I've attached a work-around patch that ignores the callback when the combo value is -1. That fixes the problem for me.

If anyone knows more about that Gtk callback behavior change, there might be a cleaner way to fix this.

Comment 5 Pascal Terjan 2007-09-19 17:42:56 UTC

It fixes the crash for me, thanks :)

Comment 6 Philip Langdale 2007-09-20 15:24:17 UTC

Committed. Thanks!

Comment 7 Yanko Kaneti 2007-10-17 03:00:14 UTC

*** Bug 487330 has been marked as a duplicate of this bug. ***

Comment 8 Yanko Kaneti 2007-12-14 17:40:54 UTC

*** Bug 501713 has been marked as a duplicate of this bug. ***

Comment 9 Yanko Kaneti 2007-12-14 17:47:14 UTC

*** Bug 492613 has been marked as a duplicate of this bug. ***

Comment 10 Yanko Kaneti 2007-12-14 17:47:31 UTC

*** Bug 493292 has been marked as a duplicate of this bug. ***

Comment 11 Yanko Kaneti 2007-12-14 17:47:51 UTC

*** Bug 495471 has been marked as a duplicate of this bug. ***

Comment 12 Yanko Kaneti 2007-12-14 17:48:06 UTC

*** Bug 496009 has been marked as a duplicate of this bug. ***

Comment 13 Yanko Kaneti 2007-12-18 05:44:51 UTC

*** Bug 504180 has been marked as a duplicate of this bug. ***

Comment 14 Yanko Kaneti 2008-01-06 23:35:12 UTC

*** Bug 507571 has been marked as a duplicate of this bug. ***

Comment 15 Yanko Kaneti 2008-01-13 12:55:22 UTC

*** Bug 509064 has been marked as a duplicate of this bug. ***

Comment 16 Yanko Kaneti 2008-01-24 14:53:31 UTC

*** Bug 511604 has been marked as a duplicate of this bug. ***

Comment 17 Yanko Kaneti 2008-02-14 06:39:22 UTC

*** Bug 516295 has been marked as a duplicate of this bug. ***