After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 459100 - add contact shouldn't display account on which the Channel_Group_Flag_Can_Add is not set
add contact shouldn't display account on which the Channel_Group_Flag_Can_Add...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2007-07-21 20:25 UTC by Guillaume Desmottes
Modified: 2008-12-12 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (18.40 KB, patch)
2007-07-22 10:45 UTC, Guillaume Desmottes
committed Details | Review
chech the Can_Add flag (5.24 KB, patch)
2008-12-01 22:14 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2007-07-21 20:25:03 UTC
As it doesn't make sense to manually add Salut contacts, Salut accounts shouldn't be displayed in the dialog.
Comment 1 Guillaume Desmottes 2007-07-22 10:45:05 UTC
Created attachment 92161 [details] [review]
fix

This patch fix that problem implementing a new empathy-account-chooser filtering API.
Currently Salut is hardcoded but at some point maybe we should add a "add-contact" capability in profile files.

This patch also improves the add contact dialog, displaying contact information when user stops to type his ID.
Comment 2 Xavier Claessens 2007-07-26 14:30:25 UTC
Committed.

We still need to refilter accounts when the status change and implement
account_chooser_account_remove_foreach().
Comment 3 Sjoerd Simons 2007-08-24 13:55:46 UTC
(In reply to comment #1)
> Created an attachment (id=92161) [edit]
> fix
> 
> This patch fix that problem implementing a new empathy-account-chooser
> filtering API.
> Currently Salut is hardcoded but at some point maybe we should add a
> "add-contact" capability in profile files.

You can look at the group flags to see if it's possible to add people at all.. For salut you can see that Channel_Group_Flag_Can_Add is disabled..
Comment 4 Xavier Claessens 2007-08-24 16:59:22 UTC
right, didn't thought about that. We need to add an API on EmpathyTpContactList to know if we can add a contact or not.
Comment 5 Xavier Claessens 2008-04-11 16:17:58 UTC
Note that now group flags should be added to EmpathyTpGroup object.
Comment 6 Guillaume Desmottes 2008-11-23 21:15:21 UTC
Same problem with telepathy-sofiasip.
Comment 7 Guillaume Desmottes 2008-11-23 21:21:38 UTC
... and telepathy-idle
Comment 8 Guillaume Desmottes 2008-12-01 22:13:34 UTC
Proposed fix:
http://monkey.collabora.co.uk/empathy.git_add-contact-459100/
http://git.collabora.co.uk/?p=user/cassidy/empathy.git;a=shortlog;h=refs/heads/add-contact-459100

Known bug: if we can't add contacts to any account, the "add button" should be insensitive. Not sure of the right way to do that.
Comment 9 Guillaume Desmottes 2008-12-01 22:14:33 UTC
Created attachment 123765 [details] [review]
chech the Can_Add flag
Comment 10 Xavier Claessens 2008-12-12 09:40:44 UTC
I fixed coding style and committed. Thanks for the branch!