After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 459014 - we shouldn't be able to enable an incomplete account
we shouldn't be able to enable an incomplete account
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
: 469494 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-07-21 16:01 UTC by Guillaume Desmottes
Modified: 2009-08-25 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.56 KB, patch)
2007-08-02 18:51 UTC, Xavier Claessens 		reviewed Details | Review
A patch for bug#459014 (2.30 KB, patch)
2007-08-29 17:54 UTC, Peter Zhu 		rejected Details | Review

Description Guillaume Desmottes 2007-07-21 16:01:03 UTC 
When we create/modify an account, the enabled/disabled button should be unsensitive while the account is not fully configured.
Comment 1 Xavier Claessens 2007-08-02 18:51:56 UTC 
Created attachment 92941 [details] [review]
patch

This patch should solve the problem but I got some problems with MC. See SF bug #1766394
Comment 2 Björn Martensen 2007-08-13 20:52:26 UTC 
haven't tried the patch, but i just wanted to let you know that the required information to enable an account should be more visible.
for example for an salut account, you need to specify the published name and the nickname, or else it can't be enabled. however the other fields can be left blank, but there is no hint whatsoever that you _have to_ fill those two fields.
such fields should be marked as in online shops, sth like this:

published name (*)
jid
email adress
nick (*)
--------
(*) = required information


or without the () ;)
Comment 3 Xavier Claessens 2007-08-14 08:00:23 UTC 
Björn > Good idea, I just opened bug #466521 for that.
Comment 4 Xavier Claessens 2007-08-23 09:40:42 UTC 
*** Bug 469494 has been marked as a duplicate of this bug. ***
Comment 5 Peter Zhu 2007-08-29 17:54:50 UTC 
Created attachment 94563 [details] [review]
A patch for bug#459014

Since MC has problem issuing "account-changed" signal, how about checking account completion status in focus-out event process of entry for required protocol parameter. The patch is for Jabber protocl. Note, I'm using old version of empathy that still used gossip_XX function. Sorry for this
Comment 6 Xavier Claessens 2007-09-21 13:33:24 UTC 
I don't like that patch because:

1) setting widgets shouldn't use EmpathyAccountsDialog, we can image other programs reusing setting widgets into another dialog not coming from libempathy-gtk.

2) All setting widgets needs to be patched the same way, not only jabber's.

I would prefer a patch in MC, it shouldn't be that hard.
Comment 8 Guillaume Desmottes 2009-08-25 14:16:25 UTC 
Marking this bug as closed as with the new accounts dialog, the "connect" button is unsensitive until all the mandatory fields have been filled.